From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A8ACA9ECB for ; Thu, 31 Oct 2019 16:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1259B2087F for ; Thu, 31 Oct 2019 16:29:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728544AbfJaQ3v (ORCPT ); Thu, 31 Oct 2019 12:29:51 -0400 Received: from foss.arm.com ([217.140.110.172]:51504 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbfJaQ3u (ORCPT ); Thu, 31 Oct 2019 12:29:50 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DC4D546A; Thu, 31 Oct 2019 09:29:49 -0700 (PDT) Received: from [192.168.1.20] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03BF13F71E; Thu, 31 Oct 2019 09:29:47 -0700 (PDT) Subject: Re: [Patch v4 5/6] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping To: Thara Gopinath , mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com, vincent.guittot@linaro.org, rui.zhang@intel.com, edubezval@gmail.com, qperret@google.com Cc: linux-kernel@vger.kernel.org, amit.kachhap@gmail.com, javi.merino@kernel.org, daniel.lezcano@linaro.org References: <1571776465-29763-1-git-send-email-thara.gopinath@linaro.org> <1571776465-29763-6-git-send-email-thara.gopinath@linaro.org> From: Dietmar Eggemann Message-ID: <2b19d7da-412c-932f-7251-110eadbef3e3@arm.com> Date: Thu, 31 Oct 2019 17:29:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1571776465-29763-6-git-send-email-thara.gopinath@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.10.19 22:34, Thara Gopinath wrote: > Thermal governors can request for a cpu's maximum supported frequency > to be capped in case of an overheat event. This in turn means that the > maximum capacity available for tasks to run on the particular cpu is > reduced. Delta between the original maximum capacity and capped > maximum capacity is known as thermal pressure. Enable cpufreq cooling > device to update the thermal pressure in event of a capped > maximum frequency. > > Signed-off-by: Thara Gopinath > --- > drivers/thermal/cpu_cooling.c | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > index 391f397..2e6a979 100644 > --- a/drivers/thermal/cpu_cooling.c > +++ b/drivers/thermal/cpu_cooling.c > @@ -218,6 +218,23 @@ static u32 cpu_power_to_freq(struct cpufreq_cooling_device *cpufreq_cdev, > } > > /** > + * update_sched_max_capacity - update scheduler about change in cpu > + * max frequency. > + * @policy - cpufreq policy whose max frequency is capped. > + */ > +static void update_sched_max_capacity(struct cpumask *cpus, > + unsigned int cur_max_freq, > + unsigned int max_freq) > +{ > + int cpu; > + unsigned long capacity = (cur_max_freq << SCHED_CAPACITY_SHIFT) / > + max_freq; > + > + for_each_cpu(cpu, cpus) > + update_thermal_pressure(cpu, capacity); > +} > + > +/** > * get_load() - get load for a cpu since last updated > * @cpufreq_cdev: &struct cpufreq_cooling_device for this cpu > * @cpu: cpu number > @@ -320,6 +337,7 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, > unsigned long state) > { > struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; > + int ret; > > /* Request state should be less than max_level */ > if (WARN_ON(state > cpufreq_cdev->max_level)) > @@ -331,8 +349,17 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, > > cpufreq_cdev->cpufreq_state = state; > > - return dev_pm_qos_update_request(&cpufreq_cdev->qos_req, > - cpufreq_cdev->freq_table[state].frequency); > + ret = dev_pm_qos_update_request > + (&cpufreq_cdev->qos_req, > + cpufreq_cdev->freq_table[state].frequency); > + > + if (ret > 0) > + update_sched_max_capacity > + (cpufreq_cdev->policy->cpus, > + cpufreq_cdev->freq_table[state].frequency, > + cpufreq_cdev->policy->cpuinfo.max_freq); > + > + return ret; > } > > /** > Why not getting rid of update_sched_max_capacity() entirely and call update_thermal_pressure() in cpu_cooling.c directly? Saves one level in the call chain and would mean less code for this feature. Just compile tested on arm64: diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 3211b4d3a899..bf36995013b0 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -217,23 +217,6 @@ static u32 cpu_power_to_freq(struct cpufreq_cooling_device *cpufreq_cdev, return freq_table[i - 1].frequency; } -/** - * update_sched_max_capacity - update scheduler about change in cpu - * max frequency. - * @policy - cpufreq policy whose max frequency is capped. - */ -static void update_sched_max_capacity(struct cpumask *cpus, - unsigned int cur_max_freq, - unsigned int max_freq) -{ - int cpu; - unsigned long capacity = (cur_max_freq << SCHED_CAPACITY_SHIFT) / - max_freq; - - for_each_cpu(cpu, cpus) - update_thermal_pressure(cpu, capacity); -} - /** * get_load() - get load for a cpu since last updated * @cpufreq_cdev: &struct cpufreq_cooling_device for this cpu @@ -353,7 +336,7 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, cpufreq_cdev->freq_table[state].frequency); if (ret > 0) - update_sched_max_capacity + update_thermal_pressure (cpufreq_cdev->policy->cpus, cpufreq_cdev->freq_table[state].frequency, cpufreq_cdev->policy->cpuinfo.max_freq); diff --git a/include/linux/sched.h b/include/linux/sched.h index 55dfe9634f67..5707813c7621 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1985,9 +1985,9 @@ static inline void rseq_syscall(struct pt_regs *regs) #endif #ifdef CONFIG_SMP -void update_thermal_pressure(int cpu, u64 capacity); +void update_thermal_pressure(struct cpumask *cpus, unsigned int cur, unsigned int max); #else -static inline void update_thermal_pressure(int cpu, u64 capacity) +static inline void update_thermal_pressure(struct cpumask *cpus, unsigned int cur, unsigned int max); { } #endif diff --git a/kernel/sched/thermal.c b/kernel/sched/thermal.c index 0da31e12a5ff..691bdd79597a 100644 --- a/kernel/sched/thermal.c +++ b/kernel/sched/thermal.c @@ -43,17 +43,16 @@ static DEFINE_PER_CPU(unsigned long, delta_capacity); * the arch_scale_cpu_capacity and capped capacity is stored in per cpu * delta_capacity. */ -void update_thermal_pressure(int cpu, u64 capped_freq_ratio) +void update_thermal_pressure(struct cpumask *cpus, unsigned int cur, unsigned int max) { - unsigned long __capacity, delta; + int cpu; - /* Normalize the capped freq ratio */ - __capacity = (capped_freq_ratio * arch_scale_cpu_capacity(cpu)) >> - SCHED_CAPACITY_SHIFT; - delta = arch_scale_cpu_capacity(cpu) - __capacity; - pr_debug("updating cpu%d thermal pressure to %lu\n", cpu, delta); + for_each_cpu(cpu, cpus) { + unsigned long scale_cap = arch_scale_cpu_capacity(cpu); + unsigned long cur_cap = cur * scale_cap / max; - per_cpu(delta_capacity, cpu) = delta; + per_cpu(delta_capacity, cpu) = scale_cap - cur_cap; + } }