From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10C4EC432BE for ; Mon, 23 Aug 2021 03:56:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E741A6126A for ; Mon, 23 Aug 2021 03:56:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233843AbhHWD5W (ORCPT ); Sun, 22 Aug 2021 23:57:22 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:15202 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232866AbhHWD5V (ORCPT ); Sun, 22 Aug 2021 23:57:21 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4GtJLt6YFzz1CZdD; Mon, 23 Aug 2021 11:56:06 +0800 (CST) Received: from dggema764-chm.china.huawei.com (10.1.198.206) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 23 Aug 2021 11:56:35 +0800 Received: from [10.174.185.179] (10.174.185.179) by dggema764-chm.china.huawei.com (10.1.198.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 23 Aug 2021 11:56:34 +0800 Subject: Re: [PATCH 1/2] bcma: Fix memory leak for internally-handled cores To: Kalle Valo CC: , , , , , References: <20210727025232.663-1-yuzenghui@huawei.com> <20210727025232.663-2-yuzenghui@huawei.com> <8943a493-aee8-3fe5-e63a-f3b61eaead14@huawei.com> <877dgfun7t.fsf@codeaurora.org> From: Zenghui Yu Message-ID: <2b218922-45b2-38cc-2a80-4d339949deed@huawei.com> Date: Mon, 23 Aug 2021 11:56:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <877dgfun7t.fsf@codeaurora.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.185.179] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggema764-chm.china.huawei.com (10.1.198.206) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/21 18:05, Kalle Valo wrote: > Zenghui Yu writes: > >> On 2021/7/27 10:52, Zenghui Yu wrote: >>> kmemleak reported that dev_name() of internally-handled cores were leaked >>> on driver unbinding. Let's use device_initialize() to take refcounts for >>> them and put_device() to properly free the related stuff. >> >> Could this be picked as a fix for v5.14 (_if_ it does fix something)? > > Why should this go to v5.14? Most probably it's too late for v5.14 > anyway. No worries. It's not urgent and just that I didn't realize we're already at rc7 now. The patch has been on the list for about 4 weeks and I'd appreciate any review comments from maintainers. Zenghui