From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B84C433F5 for ; Fri, 26 Nov 2021 09:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376335AbhKZJhW (ORCPT ); Fri, 26 Nov 2021 04:37:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232710AbhKZJfQ (ORCPT ); Fri, 26 Nov 2021 04:35:16 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FF24C0613E0; Fri, 26 Nov 2021 01:26:21 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 5C18E1F46742 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1637918779; bh=RZZMdLZe+frl5NeinRGjT60ZCs3bDCTm8bd2vGIWYxU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=CMSPNnmkh8LJZdT2NGjAofryIcTSQ9/lo/FTRbyld5ugGLnF6+IOhNXdNEEL2aIoM n2cQTnwp6DsiX7xLZgqi9TYa72PSqU502GYiJUQWJz2yZWY8g1QrVpIIhVzuwQq2vI 6eWCGzgGf00rZlyVZ1z3xJ7BTPGfUi9Xns3Td0A9i/01y4QXgIkXc+0AZ6eRawjArj rXGFCmzKd6T01mCYFwXiy2KSDGeIiizDWjRMzqgvUHm3i9sAaD7uBfB4wBcdRek2tv Fp/+Ti49MMnGx7R8MpUplhvp78kM59133FijmDYbfGPPrJpSiKSsMt31WPh8YsFCk1 bh6e5KeOTe9UA== Subject: Re: [PATCH] drm/msm: Initialize MDSS irq domain at probe time To: Dmitry Baryshkov , robdclark@gmail.com Cc: sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, maxime@cerno.tech, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, jami.kettunen@somainline.org References: <20211125150947.354076-1-angelogioacchino.delregno@collabora.com> <32cdade5-1487-9182-e939-4d93f8a27ad6@linaro.org> From: AngeloGioacchino Del Regno Message-ID: <2b37dfd3-c3be-2640-56d0-25c9971c4f50@collabora.com> Date: Fri, 26 Nov 2021 10:26:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <32cdade5-1487-9182-e939-4d93f8a27ad6@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/11/21 01:06, Dmitry Baryshkov ha scritto: > On 25/11/2021 18:09, AngeloGioacchino Del Regno wrote: >> Since commit 8f59ee9a570c ("drm/msm/dsi: Adjust probe order"), the >> DSI host gets initialized earlier, but this caused unability to probe >> the entire stack of components because they all depend on interrupts >> coming from the main `mdss` node (mdp5, or dpu1). >> >> To fix this issue, also anticipate probing mdp5 or dpu1 by initializing >> them at msm_pdev_probe() time: this will make sure that we add the >> required interrupt controller mapping before dsi and/or other components >> try to initialize, finally satisfying the dependency. >> >> While at it, also change the allocation of msm_drm_private to use the >> devm variant of kzalloc(). >> >> Fixes: 8f59ee9a570c ("drm/msm/dsi: Adjust probe order") >> Signed-off-by: AngeloGioacchino Del Regno > > Another issue (or a pack of issues): > Now the msm_drm_init() is unbalanced with msm_drm_uninit(). Bits of code (putting > the drm dev, removing the IRQ domain, etc) have to be called now from the > msm_pdev_remove() function rather than from the unbind path. > > The following changes fix the observed issues here, however additional care should > be taken. > Hello Dmitry, thanks for the thorough review (and solutions!). Are you going to push your changes on top, or should I send a V2? Cheers, - Angelo