From: Joe Perches <joe@perches.com>
To: Song Liu <songliubraving@fb.com>, linux-kernel@vger.kernel.org
Cc: bpf@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH v3] checkpatch: do not apply "initialise globals to 0" check to BPF progs
Date: Tue, 09 Feb 2021 10:59:30 -0800 [thread overview]
Message-ID: <2b41e46fcf909bd67a578524107214fe4b1eeede.camel@perches.com> (raw)
In-Reply-To: <20210209183343.3929160-1-songliubraving@fb.com>
On Tue, 2021-02-09 at 10:33 -0800, Song Liu wrote:
> BPF programs explicitly initialise global variables to 0 to make sure
> clang (v10 or older) do not put the variables in the common section.
> Skip "initialise globals to 0" check for BPF programs to elimiate error
> messages like:
>
> ERROR: do not initialise globals to 0
> #19: FILE: samples/bpf/tracex1_kern.c:21:
>
> Cc: Andy Whitcroft <apw@canonical.com>
> Cc: Joe Perches <joe@perches.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
>
> ---
> Changes v2 => v3:
> 1. Fix regex.
Unfortunately, this has broken regexes...
> Changes v1 => v2:
> 1. Add function exclude_global_initialisers() to keep the code clean.
> ---
> scripts/checkpatch.pl | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2428,6 +2428,15 @@ sub get_raw_comment {
> return $comment;
> }
>
> +sub exclude_global_initialisers {
> + my ($realfile) = @_;
> +
> + # Do not check for BPF programs (tools/testing/selftests/bpf/progs/*.c, samples/bpf/*_kern.c, *.bpf.c).
> + return $realfile =~ m@/^tools\/testing\/selftests\/bpf\/progs\/.*\.c@ ||
You don't need to escape the / when using m@@, and this doesn't work
given the leading / after @, and it should use a trailing $
return $realfile =~ m@^tools/testing/selftests/bpf/progs/.*\.c$@ ||
> + $realfile =~ m@^samples\/bpf\/.*_kern.c@ ||
This is still missing an escape on the . before c@, and there's no
trailing $ between c and @
$realfile =~ m@^samples/bpf/.*_kern\.c$@ ||
> + $realfile =~ m@/bpf/.*\.bpf\.c$@;
I believe I showed the correct regexes in my earlier reply.
next prev parent reply other threads:[~2021-02-10 0:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 18:33 [PATCH v3] checkpatch: do not apply "initialise globals to 0" check to BPF progs Song Liu
2021-02-09 18:59 ` Joe Perches [this message]
2021-02-09 19:44 ` Song Liu
2021-02-09 19:57 ` Joe Perches
2021-02-09 21:19 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b41e46fcf909bd67a578524107214fe4b1eeede.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).