From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 549D3C3A59F for ; Mon, 26 Aug 2019 19:33:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23B322186A for ; Mon, 26 Aug 2019 19:33:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733200AbfHZTd2 (ORCPT ); Mon, 26 Aug 2019 15:33:28 -0400 Received: from foss.arm.com ([217.140.110.172]:34418 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729780AbfHZTd2 (ORCPT ); Mon, 26 Aug 2019 15:33:28 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6AA0C337; Mon, 26 Aug 2019 12:33:27 -0700 (PDT) Received: from [10.37.9.91] (unknown [10.37.9.91]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3822F3F246; Mon, 26 Aug 2019 12:33:25 -0700 (PDT) Subject: Re: [RFC PATCH 0/7] Unify SMP stop generic logic to common code To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mark.rutland@arm.com, peterz@infradead.org, catalin.marinas@arm.com, takahiro.akashi@linaro.org, james.morse@arm.com, hidehiro.kawai.ez@hitachi.com, tglx@linutronix.de, will@kernel.org, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org References: <20190823115720.605-1-cristian.marussi@arm.com> <20190826153401.GB9591@infradead.org> From: Cristian Marussi Message-ID: <2b4a744c-ea20-00e6-828f-7be125326792@arm.com> Date: Mon, 26 Aug 2019 20:33:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190826153401.GB9591@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph thanks for the review. On 8/26/19 4:34 PM, Christoph Hellwig wrote: > On Fri, Aug 23, 2019 at 12:57:13PM +0100, Cristian Marussi wrote: >> An architecture willing to rely on this SMP common logic has to define its >> own helpers and set CONFIG_ARCH_USE_COMMON_SMP_STOP=y. >> The series wire this up for arm64. >> >> Behaviour is not changed for architectures not adopting this new common >> logic. > > Seens like this common code only covers arm64. I think we should > generally have at least two users for common code. > Yes absolutely, but this RFC was an attempt at first to explore if this approach was deemed sensible upstream or not, so I wired up only arm64 for now. Thanks Cristian