From: Larry Finger <Larry.Finger@lwfinger.net>
To: MosesChristopher <moseschristopherb@gmail.com>,
gregkh@linuxfoundation.org, florian.c.schilhabel@googlemail.com,
insafonov@gmail.com, hdegoede@redhat.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8*: use help instead of ---help--- in Kconfig
Date: Sat, 20 Apr 2019 12:00:53 -0500 [thread overview]
Message-ID: <2b4f1a3d-b5c3-98e6-fd85-32205312e26a@lwfinger.net> (raw)
In-Reply-To: <20190420113731.26160-1-moseschristopherb@gmail.com>
On 4/20/19 6:37 AM, MosesChristopher wrote:
> From: Moses Christopher <moseschristopherb@gmail.com>
>
> - Resolve the following warning from the Kconfig,
> "WARNING: prefer 'help' over '---help---' for new help texts"
>
> Signed-off-by: Moses Christopher <moseschristopherb@gmail.com>
I have never seen this warning, but your Kconfig may be newer than mine. In any
case, the changes are harmless.
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> drivers/staging/rtl8188eu/Kconfig | 4 ++--
> drivers/staging/rtl8192e/Kconfig | 8 ++++----
> drivers/staging/rtl8712/Kconfig | 4 ++--
> drivers/staging/rtl8723bs/Kconfig | 2 +-
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/Kconfig b/drivers/staging/rtl8188eu/Kconfig
> index ff7832798a77..3f8c655856bf 100644
> --- a/drivers/staging/rtl8188eu/Kconfig
> +++ b/drivers/staging/rtl8188eu/Kconfig
> @@ -7,7 +7,7 @@ config R8188EU
> select LIB80211
> select LIB80211_CRYPT_WEP
> select LIB80211_CRYPT_CCMP
> - ---help---
> + help
> This option adds the Realtek RTL8188EU USB device such as TP-Link TL-WN725N.
> If built as a module, it will be called r8188eu.
>
> @@ -16,7 +16,7 @@ if R8188EU
> config 88EU_AP_MODE
> bool "Realtek RTL8188EU AP mode"
> default y
> - ---help---
> + help
> This option enables Access Point mode. Unless you know that your system
> will never be used as an AP, or the target system has limited memory,
> "Y" should be selected.
> diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig
> index 4602a47cdb4a..aa571c12678f 100644
> --- a/drivers/staging/rtl8192e/Kconfig
> +++ b/drivers/staging/rtl8192e/Kconfig
> @@ -3,7 +3,7 @@ config RTLLIB
> depends on WLAN && m
> default n
> select LIB80211
> - ---help---
> + help
> If you have a wireless card that uses rtllib, say
> Y. Currently the only card is the rtl8192e.
>
> @@ -16,7 +16,7 @@ config RTLLIB_CRYPTO_CCMP
> depends on RTLLIB
> select CRYPTO_AES
> default y
> - ---help---
> + help
> CCMP crypto driver for rtllib.
>
> If you enabled RTLLIB, you want this.
> @@ -27,7 +27,7 @@ config RTLLIB_CRYPTO_TKIP
> select CRYPTO_ARC4
> select CRYPTO_MICHAEL_MIC
> default y
> - ---help---
> + help
> TKIP crypto driver for rtllib.
>
> If you enabled RTLLIB, you want this.
> @@ -37,7 +37,7 @@ config RTLLIB_CRYPTO_WEP
> select CRYPTO_ARC4
> depends on RTLLIB
> default y
> - ---help---
> + help
> TKIP crypto driver for rtllib.
>
> If you enabled RTLLIB, you want this.
> diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
> index f160eee52f09..b377d90742db 100644
> --- a/drivers/staging/rtl8712/Kconfig
> +++ b/drivers/staging/rtl8712/Kconfig
> @@ -4,14 +4,14 @@ config R8712U
> select WIRELESS_EXT
> select WEXT_PRIV
> select FW_LOADER
> - ---help---
> + help
> This option adds the Realtek RTL8712 USB device such as the D-Link DWA-130.
> If built as a module, it will be called r8712u.
>
> config R8712_TX_AGGR
> bool "Realtek RTL8712U Transmit Aggregation code"
> depends on R8712U && BROKEN
> - ---help---
> + help
> This option provides transmit aggregation for the Realtek RTL8712 USB device.
>
>
> diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
> index deae0427ba6c..41ad6ed24860 100644
> --- a/drivers/staging/rtl8723bs/Kconfig
> +++ b/drivers/staging/rtl8723bs/Kconfig
> @@ -4,7 +4,7 @@ config RTL8723BS
> depends on m
> select WIRELESS_EXT
> select WEXT_PRIV
> - ---help---
> + help
> This option enables support for RTL8723BS SDIO drivers, such as
> the wifi found on the 1st gen Intel Compute Stick, the CHIP
> and many other Intel Atom and ARM based devices.
>
prev parent reply other threads:[~2019-04-20 17:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-20 11:37 [PATCH] staging: rtl8*: use help instead of ---help--- in Kconfig MosesChristopher
2019-04-20 17:00 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b4f1a3d-b5c3-98e6-fd85-32205312e26a@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=insafonov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moseschristopherb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).