* [PATCH][next] firewire: core: Fix fall-through warnings for Clang
@ 2021-03-05 7:42 Gustavo A. R. Silva
2021-04-20 20:12 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 7:42 UTC (permalink / raw)
To: Stefan Richter
Cc: linux1394-devel, linux-kernel, Gustavo A. R. Silva, linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a fallthrough pseudo-keyword.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/firewire/core-topology.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firewire/core-topology.c b/drivers/firewire/core-topology.c
index ec68ed27b0a5..b63d55f5ebd3 100644
--- a/drivers/firewire/core-topology.c
+++ b/drivers/firewire/core-topology.c
@@ -58,6 +58,7 @@ static u32 *count_ports(u32 *sid, int *total_port_count, int *child_port_count)
case SELFID_PORT_PARENT:
case SELFID_PORT_NCONN:
(*total_port_count)++;
+ fallthrough;
case SELFID_PORT_NONE:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] firewire: core: Fix fall-through warnings for Clang
2021-03-05 7:42 [PATCH][next] firewire: core: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-20 20:12 ` Gustavo A. R. Silva
2021-05-18 0:41 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:12 UTC (permalink / raw)
To: Gustavo A. R. Silva, Stefan Richter
Cc: linux1394-devel, linux-kernel, linux-hardening
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 01:42, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a fallthrough pseudo-keyword.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/firewire/core-topology.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firewire/core-topology.c b/drivers/firewire/core-topology.c
> index ec68ed27b0a5..b63d55f5ebd3 100644
> --- a/drivers/firewire/core-topology.c
> +++ b/drivers/firewire/core-topology.c
> @@ -58,6 +58,7 @@ static u32 *count_ports(u32 *sid, int *total_port_count, int *child_port_count)
> case SELFID_PORT_PARENT:
> case SELFID_PORT_NCONN:
> (*total_port_count)++;
> + fallthrough;
> case SELFID_PORT_NONE:
> break;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] firewire: core: Fix fall-through warnings for Clang
2021-04-20 20:12 ` Gustavo A. R. Silva
@ 2021-05-18 0:41 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18 0:41 UTC (permalink / raw)
To: Gustavo A. R. Silva, Stefan Richter
Cc: linux1394-devel, linux-kernel, linux-hardening
Hi,
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Thanks
--
Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/20/21 15:12, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 3/5/21 01:42, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a fallthrough pseudo-keyword.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> drivers/firewire/core-topology.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/firewire/core-topology.c b/drivers/firewire/core-topology.c
>> index ec68ed27b0a5..b63d55f5ebd3 100644
>> --- a/drivers/firewire/core-topology.c
>> +++ b/drivers/firewire/core-topology.c
>> @@ -58,6 +58,7 @@ static u32 *count_ports(u32 *sid, int *total_port_count, int *child_port_count)
>> case SELFID_PORT_PARENT:
>> case SELFID_PORT_NCONN:
>> (*total_port_count)++;
>> + fallthrough;
>> case SELFID_PORT_NONE:
>> break;
>> }
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-18 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 7:42 [PATCH][next] firewire: core: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:12 ` Gustavo A. R. Silva
2021-05-18 0:41 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).