From: Jens Axboe <axboe@kernel.dk>
To: SunKe <sunke32@huawei.com>,
josef@toxicpanda.com, linux-block@vger.kernel.org,
nbd@other.debian.org, linux-kernel@vger.kernel.org,
kamatam@amazon.com, manoj.br@gmail.com, stable@vger.kernel.org,
dwmw@amazon.com
Subject: Re: [PATCH v2] nbd: replace kill_bdev() with __invalidate_device() again
Date: Wed, 31 Jul 2019 08:52:09 -0600 [thread overview]
Message-ID: <2b77d06d-3610-b2f7-d95f-8925b6bd49bf@kernel.dk> (raw)
In-Reply-To: <1564575190-132357-1-git-send-email-sunke32@huawei.com>
On 7/31/19 6:13 AM, SunKe wrote:
> From: Munehisa Kamata <kamatam@amazon.com>
>
> Commit abbbdf12497d ("replace kill_bdev() with __invalidate_device()")
> once did this, but 29eaadc03649 ("nbd: stop using the bdev everywhere")
> resurrected kill_bdev() and it has been there since then. So buffer_head
> mappings still get killed on a server disconnection, and we can still
> hit the BUG_ON on a filesystem on the top of the nbd device.
>
> EXT4-fs (nbd0): mounted filesystem with ordered data mode. Opts: (null)
> block nbd0: Receive control failed (result -32)
> block nbd0: shutting down sockets
> print_req_error: I/O error, dev nbd0, sector 66264 flags 3000
> EXT4-fs warning (device nbd0): htree_dirblock_to_tree:979: inode #2: lblock 0: comm ls: error -5 reading directory block
> print_req_error: I/O error, dev nbd0, sector 2264 flags 3000
> EXT4-fs error (device nbd0): __ext4_get_inode_loc:4690: inode #2: block 283: comm ls: unable to read itable block
> EXT4-fs error (device nbd0) in ext4_reserve_inode_write:5894: IO failure
> ------------[ cut here ]------------
> kernel BUG at fs/buffer.c:3057!
> invalid opcode: 0000 [#1] SMP PTI
> CPU: 7 PID: 40045 Comm: jbd2/nbd0-8 Not tainted 5.1.0-rc3+ #4
> Hardware name: Amazon EC2 m5.12xlarge/, BIOS 1.0 10/16/2017
> RIP: 0010:submit_bh_wbc+0x18b/0x190
> ...
> Call Trace:
> jbd2_write_superblock+0xf1/0x230 [jbd2]
> ? account_entity_enqueue+0xc5/0xf0
> jbd2_journal_update_sb_log_tail+0x94/0xe0 [jbd2]
> jbd2_journal_commit_transaction+0x12f/0x1d20 [jbd2]
> ? __switch_to_asm+0x40/0x70
> ...
> ? lock_timer_base+0x67/0x80
> kjournald2+0x121/0x360 [jbd2]
> ? remove_wait_queue+0x60/0x60
> kthread+0xf8/0x130
> ? commit_timeout+0x10/0x10 [jbd2]
> ? kthread_bind+0x10/0x10
> ret_from_fork+0x35/0x40
>
> With __invalidate_device(), I no longer hit the BUG_ON with sync or
> unmount on the disconnected device.
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2019-07-31 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:13 [PATCH v2] nbd: replace kill_bdev() with __invalidate_device() again SunKe
2019-07-31 13:50 ` Josef Bacik
2019-07-31 14:52 ` Jens Axboe [this message]
2019-07-31 23:38 ` Munehisa Kamata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b77d06d-3610-b2f7-d95f-8925b6bd49bf@kernel.dk \
--to=axboe@kernel.dk \
--cc=dwmw@amazon.com \
--cc=josef@toxicpanda.com \
--cc=kamatam@amazon.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manoj.br@gmail.com \
--cc=nbd@other.debian.org \
--cc=stable@vger.kernel.org \
--cc=sunke32@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).