From: "Xu, Yanfei" <yanfei.xu@windriver.com>
To: David Hildenbrand <david@redhat.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/memory.c: Correct the function name in comment
Date: Tue, 18 Aug 2020 18:26:27 +0800 [thread overview]
Message-ID: <2b9b69bd-cbf8-55f9-72f7-b3c3d24b14fa@windriver.com> (raw)
In-Reply-To: <0eb405b4-a9a3-1840-0ca6-f9a801ab701c@redhat.com>
On 8/18/20 3:34 PM, David Hildenbrand wrote:
> On 18.08.20 09:29, yanfei.xu@windriver.com wrote:
>> From: Yanfei Xu <yanfei.xu@windriver.com>
>>
>> Correct the function name which is "pte_alloc_pne" to "pte_alloc_one"
>>
>
> I'd have phrased this like
>
> "mm/memory: Fix typo in __do_fault() comment
>
> It's "pte_alloc_one", not "pte_alloc_pne". Let's fix that.
> "
>
Hah, yours is more clear. I'll send a v2
Thanks for your suggestion. :)
//Yanfei
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
>> Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
>> ---
>> mm/memory.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memory.c b/mm/memory.c
>> index c3a83f4ca851..9cc3d0dc816c 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -3446,7 +3446,7 @@ static vm_fault_t __do_fault(struct vm_fault *vmf)
>> * unlock_page(A)
>> * lock_page(B)
>> * lock_page(B)
>> - * pte_alloc_pne
>> + * pte_alloc_one
>> * shrink_page_list
>> * wait_on_page_writeback(A)
>> * SetPageWriteback(B)
>>
>
>
prev parent reply other threads:[~2020-08-18 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 7:29 [PATCH] mm/memory.c: Correct the function name in comment yanfei.xu
2020-08-18 7:34 ` David Hildenbrand
2020-08-18 10:26 ` Xu, Yanfei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b9b69bd-cbf8-55f9-72f7-b3c3d24b14fa@windriver.com \
--to=yanfei.xu@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).