linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] led: pca9532: Use default trigger value from platform data
@ 2016-10-26 14:08 ` Felix Brack
  2016-10-26 14:45   ` Jacek Anaszewski
  0 siblings, 1 reply; 2+ messages in thread
From: Felix Brack @ 2016-10-26 14:08 UTC (permalink / raw)
  To: riku.voipio, linux-leds; +Cc: rpurdie, j.anaszewski, linux-kernel, Brack Felix

The value for a led's default_trigger should come from platform data
instead of data (which is always 0).

Signed-off-by: Felix Brack <fb@ltec.ch>
---

diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index 09a7cffb..06e6310 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -369,7 +369,7 @@ static int pca9532_configure(struct i2c_client *client,
 			led->state = pled->state;
 			led->name = pled->name;
 			led->ldev.name = led->name;
-			led->ldev.default_trigger = led->default_trigger;
+			led->ldev.default_trigger = pled->default_trigger;
 			led->ldev.brightness = LED_OFF;
 			led->ldev.brightness_set_blocking =
 						pca9532_set_brightness;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] led: pca9532: Use default trigger value from platform data
  2016-10-26 14:08 ` [PATCH] led: pca9532: Use default trigger value from platform data Felix Brack
@ 2016-10-26 14:45   ` Jacek Anaszewski
  0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2016-10-26 14:45 UTC (permalink / raw)
  To: Felix Brack, riku.voipio, linux-leds; +Cc: rpurdie, linux-kernel

Hi Felix,

Thanks for the patch. Applied.

On 10/26/2016 04:08 PM, Felix Brack wrote:
> The value for a led's default_trigger should come from platform data
> instead of data (which is always 0).
>
> Signed-off-by: Felix Brack <fb@ltec.ch>
> ---
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index 09a7cffb..06e6310 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -369,7 +369,7 @@ static int pca9532_configure(struct i2c_client *client,
>  			led->state = pled->state;
>  			led->name = pled->name;
>  			led->ldev.name = led->name;
> -			led->ldev.default_trigger = led->default_trigger;
> +			led->ldev.default_trigger = pled->default_trigger;
>  			led->ldev.brightness = LED_OFF;
>  			led->ldev.brightness_set_blocking =
>  						pca9532_set_brightness;
>
>
>


-- 
Best regards,
Jacek Anaszewski

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-26 14:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20161026140813eucas1p2bd4e4dc825badc0538f8d074056444c2@eucas1p2.samsung.com>
2016-10-26 14:08 ` [PATCH] led: pca9532: Use default trigger value from platform data Felix Brack
2016-10-26 14:45   ` Jacek Anaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).