From: Adrian Hunter <adrian.hunter@intel.com>
To: Masami Hiramatsu <mhiramat@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Numfor Mbiziwo-Tiapo <nums@google.com>,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, songliubraving@fb.com, mbd@fb.com,
linux-kernel@vger.kernel.org, irogers@google.com,
eranian@google.com
Subject: Re: [PATCH 3/3] Fix insn.c misaligned address error
Date: Mon, 29 Jul 2019 11:22:34 +0300 [thread overview]
Message-ID: <2bc0fcc6-0477-ba1d-7418-5497efa7d571@intel.com> (raw)
In-Reply-To: <20190727184638.3263eb76c3cbde95f9896210@kernel.org>
On 27/07/19 12:46 PM, Masami Hiramatsu wrote:
> On Fri, 26 Jul 2019 16:38:06 -0300
> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
>> Em Wed, Jul 24, 2019 at 11:45:12AM -0700, Numfor Mbiziwo-Tiapo escreveu:
>>> The ubsan (undefined behavior sanitizer) version of perf throws an
>>> error on the 'x86 instruction decoder - new instructions' function
>>> of perf test.
>>>
>>> To reproduce this run:
>>> make -C tools/perf USE_CLANG=1 EXTRA_CFLAGS="-fsanitize=undefined"
>>>
>>> then run: tools/perf/perf test 62 -v
>>>
>>> The error occurs in the __get_next macro (line 34) where an int is
>>> read from a potentially unaligned address. Using memcpy instead of
>>> assignment from an unaligned pointer.
>>
>> Since this came from the kernel, don't we have to fix it there as well?
>> Masami, Adrian?
>
> I guess we don't need it, since x86 can access "unaligned address" and
> x86 insn decoder in kernel runs only on x86. I'm not sure about perf's
> that part. Maybe if we run it on other arch as cross-arch application,
> it may cause unaligned pointer issue.
Yes, theoretically Intel PT decoding can be done on any arch.
But the memcpy is probably sub-optimal for x86, so the patch as it stands
does not seem suitable. I notice the kernel has get_unaligned() and
put_unaligned().
Obviously it would be better for a patch to be accepted to
arch/x86/lib/insn.c also.
>
> Thank you,
>
>>
>> [acme@quaco perf]$ find . -name insn.c
>> ./arch/x86/lib/insn.c
>> ./arch/arm/kernel/insn.c
>> ./arch/arm64/kernel/insn.c
>> ./tools/objtool/arch/x86/lib/insn.c
>> ./tools/perf/util/intel-pt-decoder/insn.c
>> [acme@quaco perf]$ diff -u ./tools/perf/util/intel-pt-decoder/insn.c ./arch/x86/lib/insn.c
>> --- ./tools/perf/util/intel-pt-decoder/insn.c 2019-07-06 16:59:05.734265998 -0300
>> +++ ./arch/x86/lib/insn.c 2019-07-06 16:59:01.369202998 -0300
>> @@ -10,8 +10,8 @@
>> #else
>> #include <string.h>
>> #endif
>> -#include "inat.h"
>> -#include "insn.h"
>> +#include <asm/inat.h>
>> +#include <asm/insn.h>
>>
>> /* Verify next sizeof(t) bytes can be on the same instruction */
>> #define validate_next(t, insn, n) \
>> [acme@quaco perf]$
>>
>>
>> - Arnaldo
>>
>>> Signed-off-by: Numfor Mbiziwo-Tiapo <nums@google.com>
>>> ---
>>> tools/perf/util/intel-pt-decoder/insn.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/perf/util/intel-pt-decoder/insn.c b/tools/perf/util/intel-pt-decoder/insn.c
>>> index ca983e2bea8b..de1944c60aa9 100644
>>> --- a/tools/perf/util/intel-pt-decoder/insn.c
>>> +++ b/tools/perf/util/intel-pt-decoder/insn.c
>>> @@ -31,7 +31,8 @@
>>> ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr)
>>>
>>> #define __get_next(t, insn) \
>>> - ({ t r = *(t*)insn->next_byte; insn->next_byte += sizeof(t); r; })
>>> + ({ t r; memcpy(&r, insn->next_byte, sizeof(t)); \
>>> + insn->next_byte += sizeof(t); r; })
>>>
>>> #define __peek_nbyte_next(t, insn, n) \
>>> ({ t r = *(t*)((insn)->next_byte + n); r; })
>>> --
>>> 2.22.0.657.g960e92d24f-goog
>>
>> --
>>
>> - Arnaldo
>
>
next prev parent reply other threads:[~2019-07-29 8:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 18:45 [PATCH 0/3] Perf UBsan Patches Numfor Mbiziwo-Tiapo
2019-07-24 18:45 ` [PATCH 1/3] Fix backward-ring-buffer.c format-truncation error Numfor Mbiziwo-Tiapo
2019-07-25 13:08 ` David Laight
2019-07-26 19:40 ` Arnaldo Carvalho de Melo
2019-07-29 20:57 ` [PATCH v2] Fix annotate.c use of uninitialized value error Numfor Mbiziwo-Tiapo
2019-08-07 11:32 ` Jiri Olsa
2019-10-25 22:11 ` Ian Rogers
2020-07-09 0:54 ` Ian Rogers
2020-07-09 15:38 ` Arnaldo Carvalho de Melo
2019-07-24 18:45 ` [PATCH 2/3] Fix ordered-events.c array-bounds error Numfor Mbiziwo-Tiapo
2019-07-26 19:33 ` Arnaldo Carvalho de Melo
2019-07-26 19:35 ` Arnaldo Carvalho de Melo
2019-07-24 18:45 ` [PATCH 3/3] Fix insn.c misaligned address error Numfor Mbiziwo-Tiapo
2019-07-25 13:06 ` David Laight
2019-07-25 21:18 ` Ian Rogers
2019-07-26 19:38 ` Arnaldo Carvalho de Melo
2019-07-27 9:46 ` Masami Hiramatsu
2019-07-29 8:22 ` Adrian Hunter [this message]
2019-07-29 19:32 ` Ian Rogers
2019-07-30 7:50 ` Adrian Hunter
2019-07-30 0:47 ` Masami Hiramatsu
2019-07-30 7:53 ` Adrian Hunter
2019-07-30 9:17 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bc0fcc6-0477-ba1d-7418-5497efa7d571@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbd@fb.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nums@google.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).