From: Chao Yu <yuchao0@huawei.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE
Date: Thu, 5 Nov 2020 09:00:59 +0800 [thread overview]
Message-ID: <2bec3d16-e920-12b9-562d-0e055c1af28e@huawei.com> (raw)
In-Reply-To: <20201104180153.GB846@sol.localdomain>
On 2020/11/5 2:01, Eric Biggers wrote:
> On Wed, Nov 04, 2020 at 02:43:10PM +0800, Chao Yu wrote:
>> +static int f2fs_ioc_gc_range(struct file *filp, unsigned long arg)
>> +{
>> + struct f2fs_gc_range range;
>> + struct f2fs_sb_info *sbi = F2FS_I_SB(file_inode(filp));
>> +
>> + if (!capable(CAP_SYS_ADMIN))
>> + return -EPERM;
>> + if (f2fs_readonly(sbi->sb))
>> + return -EROFS;
>> + if (copy_from_user(&range, (struct f2fs_gc_range __user *)arg,
>> + sizeof(range)))
>> + return -EFAULT;
>> +
>> + return __f2fs_ioc_gc_range(filp, &range);
>> +}
> [...]
>> #ifdef CONFIG_COMPAT
>> +static int f2fs_compat_ioc_gc_range(struct file *file, unsigned long arg)
>> +{
>> + struct f2fs_sb_info *sbi = F2FS_I_SB(file_inode(file));
>> + struct compat_f2fs_gc_range __user *urange;
>> + struct f2fs_gc_range range;
>> + int err;
>> +
>> + if (unlikely(f2fs_cp_error(sbi)))
>> + return -EIO;
>> + if (!f2fs_is_checkpoint_ready(sbi))
>> + return -ENOSPC;
>> + if (!capable(CAP_SYS_ADMIN))
>> + return -EPERM;
>> + if (f2fs_readonly(sbi->sb))
>> + return -EROFS;
>> +
>> + urange = compat_ptr(arg);
>> + err = get_user(range.sync, &urange->sync);
>> + err |= get_user(range.start, &urange->start);
>> + err |= get_user(range.len, &urange->len);
>> + if (err)
>> + return -EFAULT;
>> +
>> + return __f2fs_ioc_gc_range(file, &range);
>> +}
>
> It would be better to have __f2fs_ioc_gc_range() handle the f2fs_cp_error(),
> f2fs_is_checkpoint_ready(), capable(), and f2fs_readonly() checks, so that they
> don't have to be duplicated in the native and compat cases.
>
> Similarly for "move range".
Will clean up in v3.
Thanks,
>
> - Eric
> .
>
prev parent reply other threads:[~2020-11-05 1:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 6:43 [PATCH v2 1/2] f2fs: avoid unneeded data copy in f2fs_ioc_move_range() Chao Yu
2020-11-04 6:43 ` [PATCH v2 2/2] f2fs: fix compat F2FS_IOC_{MOVE,GARBAGE_COLLECT}_RANGE Chao Yu
2020-11-04 18:01 ` [f2fs-dev] [PATCH v2 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE Eric Biggers
2020-11-05 1:00 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bec3d16-e920-12b9-562d-0e055c1af28e@huawei.com \
--to=yuchao0@huawei.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).