From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751073AbdKEOUz (ORCPT <rfc822;w@1wt.eu>);
        Sun, 5 Nov 2017 09:20:55 -0500
Received: from mout.web.de ([212.227.15.4]:56185 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750778AbdKEOUv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 5 Nov 2017 09:20:51 -0500
Subject: Re: Sony-laptop: Adjustments for sony_nc_setup_rfkill()
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
        platform-driver-x86@vger.kernel.org
Cc: Darren Hart <dvhart@infradead.org>, Marco Chiappero <marco@absence.it>,
        Matthew Garrett <mjg@redhat.com>, Mattia Dongili <malattia@linux.it>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Andy Shevchenko <andy@infradead.org>
References: <f33d9aa0-1a8e-f702-7513-5c0d5b464529@users.sourceforge.net>
 <CAHp75VcMkXCioCzmLE0+BTmkqc5RSOx9yPO0ectVHMrMvewgwg@mail.gmail.com>
 <17ee534c-9fe6-19c4-0522-76cd3cbe5f88@users.sourceforge.net>
 <CAHp75VfaWLSwzLpnWHj0sD9ZVVbSCi+ya_+PESXjU2FbHefE0Q@mail.gmail.com>
 <340e5426-a9ba-2193-2735-85e918773785@users.sourceforge.net>
 <CAHp75VeyLnKG43g0LiDqirkehH4bLK7x216NV1+C8Oktp7D5UQ@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <2c1996c5-0833-dcd3-c747-62eca46a433d@users.sourceforge.net>
Date: Sun, 5 Nov 2017 15:20:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAHp75VeyLnKG43g0LiDqirkehH4bLK7x216NV1+C8Oktp7D5UQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:BVWWrOaAmGggvUsbwyWd3VU7rmEBfqwqOB4FY6/KyJLuHct3Vex
 cppmKW/4Cvi5fZAV+j45c2gG24adaqlrmdtr5IGZYd6alGzTyXRskhQo3rvPI5ryPjxPdcV
 1AKUkYMOwUC1JfRc1ey3eM0IbrCCEATW8IDiQId05N2F6oJFd7BbrKINW88EDKWvEIwsdwM
 HMB8Lf1vd3MLG21Q5slCQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:8cCLHvaVY20=:oRECwcEcBt07duXpqwjCpy
 AVRP93d5vkVc2V0AtmBS6frA8s0b4KvPH44/bbPExuCA9LF2JAHijm2hysRBG9L5ILmAGm/wz
 5YEd+f6Gz3OzTWO2gb7jbyiVoGkNGw8zSjBnkXRBl+YaPAW3PF72CzqIZUKtVMV8RPc5zFt0p
 zui0dAaS/a8oQlg7I34VPPgPeWuyiuD2uqxHTbt0rMqApFMP9jdxaOTZzmxFEzgX48hLA2jgO
 81o628MUZCMlY8ptn8irOeDSuWit4QF15vgStzt+CNk8rS5dRuoWdrY7U2cKqAYbCswTEnjFA
 nbmG9cW44xa2ADMR4iWXl8C3tkiLgrxY5UY9UMbfe87OmnfD5FL198l/oGvGiiaFIqGfZ6U+V
 7+YuL5Z7dr+Ml6W0PqKB28yd9Z6SsVH1fYKwlXxtiI6kdU8ayhCErWw5wD65kboPhftefOrxw
 HdcyskH0KGcTnCJ8hwA1tXrGhdMzAds8fLc//pf5Hw1nbzFi8tdcF2brtHSug37BL3GRk+W7F
 hgABGXig004N3wAh79H7PR5wgXZEdQMitNMb4TKLRW4V09k8gRBCMantIhCZIcVphVW8F7JzT
 pKRhXXjgHmF7xxw7mpVeWSw2JCg9hqUwiboHCcArDCaENxaluIwK7iDmLxbaByeN/q0YEA8Uw
 37gQDdQ5QIcf3Dy74S0O6/97c45pdYwSmKIohQdcD5haFbgJVT/nB/4z21GSiEayV1x7Vr3UX
 +ZmMKIzCaOMf0W7VS1+3PHGcowRhBk9R55RJI7H+TmTdXAKOr7yYR0pvDMUBsN6ZJKBJLyk+4
 44sW/un8bHdGToa5hJ1VBxDeS8jyKP9YchbRRaKLN5UoXLhgrs=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Do you find the following details useful for further clarification?
>>
>> text: -32
>> data: 0
>> bss:  0
> 
> ...but kernel is compiled with -O2 which,

Did you try to compare results for my update suggestion also with
the default build configuration?


> I suppose, will eliminate these repeats.

My build results did not fit to your expectations.


> So, the main question is "WHY" you are doing this change.
> 
> I didn't find any convinced explanation (yet?).

Do you find a reduction of 32 bytes for the object code not interesting
enough just by achieving such a small effect because of the replacement
of three function calls “rfkill_destroy” with goto statements?

Regards,
Markus