From: Channa <ckadabi@codeaurora.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-arm@lists.infradead.org,
linux-kernel@vger.kernel.org, tsoni@codeaurora.org,
sboyd@codeaurora.org, kyan@codeaurora.org,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Documentation for qcom,llcc
Date: Thu, 01 Feb 2018 12:47:01 -0800 [thread overview]
Message-ID: <2c343b57bf3ee8aeb3338aee0d27dc06@codeaurora.org> (raw)
In-Reply-To: <20180201104808.rxgqcrlsevtotq55@lakrids.cambridge.arm.com>
On 2018-02-01 02:48, Mark Rutland wrote:
> On Thu, Jan 25, 2018 at 03:55:12PM -0800, Channagoud Kadabi wrote:
>> Documentation for last level cache controller device tree bindings,
>> client bindings usage examples.
>>
>> Signed-off-by: Channagoud Kadabi <ckadabi@codeaurora.org>
>> ---
>> .../devicetree/bindings/arm/msm/qcom,llcc.txt | 93
>> ++++++++++++++++++++++
>> 1 file changed, 93 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
>>
>> +Example:
>> +
>> + qcom,system-cache@1300000 {
>> + compatible = "qcom,llcc-core", "syscon", "simple-mfd";
>> + reg = <0x1300000 0x50000>;
>> + reg-names = "llcc_base";
>> +
>> + llcc: qcom,sdm845-llcc {
>> + compatible = "qcom,sdm845-llcc";
>> + #cache-cells = <1>;
>> + max-slices = <32>;
>> + };
>> +
>> + qcom,llcc-ecc {
>> + compatible = "qcom,llcc-ecc";
>> + };
>> +
>> + qcom,llcc-amon {
>> + compatible = "qcom,llcc-amon";
>> + qcom,fg-cnt = <0x7>;
>> + };
>> +
>> + };
>
> The "qcom,llcc-ecc" and "qcom,llcc-amon" bindings doesn't seem to be
> used by the driver in patch 2, and it's not clear how they are intended
> to be used, so I think they should go from the binding for now.
Sure I can remove them for now and add them when the I push other
drivers
for review.
>
> I don't think you need syscon and simple-mfd, and I think you can
I used syscon and simple-mfd because three drivers touch the same
address space.
Driver 1:
system cache core: The purpose of the driver is to partition the system
cache
and program the settings such as priority, lines to probe while doing a
look up
in the system cache, low power related settings etc.
The driver also provides API for clients to query the cache slice
details,
activate and deactivate them.
Driver 2:
ECC to detect single and double bit errors in LLCC memory.
Implemented using EDAC framework.
Driver 3:
AMON: Activity Monitor to detect live lock ups in the HW block.
Implemented as SOC driver similar to driver #1.
Since the hardware block has multiple functional units the driver is
implemented
to use syscon/regmap interface.
> simplify the binding to a single node like:
>
> qcom,system-cache@1300000 {
> compatible = "qcom,sdm845-llcc";
> reg = <0x1300000 0x50000>;
> #cache-slice-cells = <1>;
> max-slices = <32>;
> }
>
> If ECC and AMON are option features, we can always add boolean
> properties for those later, e.g. "has-ecc".
>
> Thanks,
> Mark.
--
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-02-01 20:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 23:55 [PATCH 0/2] SDM845 System Cache Driver Channagoud Kadabi
2018-01-25 23:55 ` [PATCH 1/2] dt-bindings: Documentation for qcom,llcc Channagoud Kadabi
2018-02-01 10:44 ` Mark Rutland
2018-02-01 20:39 ` Channa
2018-02-02 11:05 ` Mark Rutland
2018-02-06 19:56 ` Channa
2018-02-13 14:37 ` Mark Rutland
2018-02-13 17:38 ` Channa
2018-02-01 10:48 ` Mark Rutland
2018-02-01 20:47 ` Channa [this message]
2018-02-02 11:08 ` Mark Rutland
2018-02-08 16:52 ` Matt Sealey
2018-02-09 0:24 ` Channa
2018-02-13 14:33 ` Mark Rutland
2018-01-25 23:55 ` [PATCH 2/2] drivers: soc: Add LLCC driver Channagoud Kadabi
2018-03-19 14:55 ` Jordan Crouse
2018-03-23 23:57 ` Channa
-- strict thread matches above, loose matches on Subject: below --
2018-01-16 22:35 [PATCH 0/2] SDM845 System Cache Driver Channagoud Kadabi
2018-01-16 22:35 ` [PATCH 1/2] dt-bindings: Documentation for qcom,llcc Channagoud Kadabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c343b57bf3ee8aeb3338aee0d27dc06@codeaurora.org \
--to=ckadabi@codeaurora.org \
--cc=kyan@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-arm@lists.infradead.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sboyd@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).