From: Jon Hunter <jonathanh@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Sameer Pujar <spujar@nvidia.com>, <perex@perex.cz>,
<tiwai@suse.com>, <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<atalambedu@nvidia.com>, <linux-kernel@vger.kernel.org>,
<lgirdwood@gmail.com>, <viswanathl@nvidia.com>,
<sharadg@nvidia.com>, <broonie@kernel.org>,
<thierry.reding@gmail.com>, <linux-tegra@vger.kernel.org>,
<rlokhande@nvidia.com>, <mkumard@nvidia.com>,
<dramesh@nvidia.com>
Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver
Date: Mon, 27 Jan 2020 09:45:38 +0000 [thread overview]
Message-ID: <2c3b2533-f271-4e38-6779-d82d6da40ffd@nvidia.com> (raw)
In-Reply-To: <5ed7482e-e874-9e11-c84e-7418e4b5162e@gmail.com>
On 24/01/2020 01:18, Dmitry Osipenko wrote:
> 20.01.2020 17:23, Sameer Pujar пишет:
> [snip]
>> +static int tegra_ahub_get_value_enum(struct snd_kcontrol *kctl,
>> + struct snd_ctl_elem_value *uctl)
>> +{
>> + struct snd_soc_component *cmpnt = snd_soc_dapm_kcontrol_component(kctl);
>> + struct tegra_ahub *ahub = snd_soc_component_get_drvdata(cmpnt);
>> + struct soc_enum *e = (struct soc_enum *)kctl->private_value;
>> + unsigned int reg, i, bit_pos = 0;
>> +
>> + /*
>> + * Find the bit position of current MUX input.
>> + * If nothing is set, position would be 0 and it corresponds to 'None'.
>> + */
>> + for (i = 0; i < ahub->soc_data->reg_count; i++) {
>> + unsigned int reg_val;
>> +
>> + reg = e->reg + (TEGRA210_XBAR_PART1_RX * i);
>> + snd_soc_component_read(cmpnt, reg, ®_val);
>> + reg_val &= ahub->soc_data->mask[i];
>> +
>> + if (reg_val) {
>> + bit_pos = ffs(reg_val) +
>> + (8 * cmpnt->val_bytes * i);
>
> Multiplication takes precedence, braces are not needed. Same for all
> other occurrences in the code.
Personally, I prefer the above as it is explicit and helps readability.
Jon
--
nvpublic
next prev parent reply other threads:[~2020-01-27 9:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 14:23 [PATCH 0/9] add ASoC components for AHUB Sameer Pujar
2020-01-20 14:23 ` [PATCH 1/9] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-01-20 14:23 ` [PATCH 2/9] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-01-20 15:58 ` [alsa-devel] " Dmitry Osipenko
2020-01-21 4:41 ` Sameer Pujar
2020-01-21 16:04 ` Dmitry Osipenko
2020-01-27 5:11 ` Sameer Pujar
2020-01-28 22:40 ` Dmitry Osipenko
2020-01-20 14:23 ` [PATCH 3/9] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-01-20 14:23 ` [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-01-21 5:15 ` [alsa-devel] " Dmitry Osipenko
2020-01-21 14:21 ` Sameer Pujar
2020-01-21 16:03 ` Dmitry Osipenko
2020-01-22 4:32 ` Sameer Pujar
2020-01-22 6:23 ` Dmitry Osipenko
2020-01-22 7:16 ` Sameer Pujar
2020-01-22 11:52 ` Jon Hunter
2020-01-22 16:27 ` Dmitry Osipenko
2020-01-23 9:22 ` Sameer Pujar
2020-01-23 15:16 ` Dmitry Osipenko
2020-01-24 9:07 ` Jon Hunter
2020-01-24 9:51 ` Jon Hunter
2020-01-24 14:04 ` Dmitry Osipenko
2020-01-27 5:22 ` Sameer Pujar
2020-01-29 3:41 ` Dmitry Osipenko
2020-02-14 14:05 ` Jon Hunter
2020-02-18 1:00 ` Dmitry Osipenko
2020-02-19 16:10 ` Sameer Pujar
2020-01-22 16:26 ` Dmitry Osipenko
2020-01-20 14:23 ` [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-01-24 1:18 ` [alsa-devel] " Dmitry Osipenko
2020-01-24 3:39 ` Sameer Pujar
2020-01-24 4:28 ` Dmitry Osipenko
2020-01-27 9:45 ` Jon Hunter [this message]
2020-01-20 14:23 ` [PATCH 6/9] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-01-20 14:23 ` [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-01-24 1:28 ` [alsa-devel] " Dmitry Osipenko
2020-01-24 3:27 ` Sameer Pujar
2020-01-24 4:25 ` Dmitry Osipenko
2020-01-27 5:08 ` Sameer Pujar
2020-01-20 14:23 ` [PATCH 8/9] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-01-20 14:23 ` [PATCH 9/9] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-01-28 10:49 ` [PATCH 0/9] add ASoC components for AHUB Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c3b2533-f271-4e38-6779-d82d6da40ffd@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dramesh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).