From: Charan Teja Kalla <quic_charante@quicinc.com>
To: Mark Hemment <markhemm@googlemail.com>
Cc: <hughd@google.com>, Andrew Morton <akpm@linux-foundation.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>, <vbabka@suse.cz>,
<rientjes@google.com>, <mhocko@suse.com>, <surenb@google.com>,
<shakeelb@google.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
Charan Teja Reddy <charante@codeaurora.org>
Subject: Re: [PATCH v3 RESEND] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem
Date: Mon, 10 Jan 2022 15:51:39 +0530 [thread overview]
Message-ID: <2c66ba2e-1c65-3bdd-b91e-eb8391ec6dbf@quicinc.com> (raw)
In-Reply-To: <CANe_+UipVZRZeWqzXezacPaVb9UeC6a_ZhQp8GkrvftbRktotg@mail.gmail.com>
Thanks Mark for the review!!
On 1/7/2022 5:40 PM, Mark Hemment wrote:
> On Thu, 6 Jan 2022 at 17:06, Charan Teja Reddy
> <quic_charante@quicinc.com> wrote:
>>
>> From: Charan Teja Reddy <charante@codeaurora.org>
>>
>> Currently fadvise(2) is supported only for the files that doesn't
>> associated with noop_backing_dev_info thus for the files, like shmem,
>> fadvise results into NOP. But then there is file_operations->fadvise()
>> that lets the file systems to implement their own fadvise
>> implementation. Use this support to implement some of the POSIX_FADV_XXX
>> functionality for shmem files.
>>
>> [snip]
>
>> +static int shmem_fadvise_willneed(struct address_space *mapping,
>> + pgoff_t start, pgoff_t long end)
>> +{
>> + XA_STATE(xas, &mapping->i_pages, start);
>> + struct page *page;
>> +
>> + rcu_read_lock();
>> + xas_for_each(&xas, page, end) {
>> + if (!xa_is_value(page))
>> + continue;
>> + xas_pause(&xas);
>> + rcu_read_unlock();
>> +
>> + page = shmem_read_mapping_page(mapping, xas.xa_index);
>> + if (!IS_ERR(page))
>> + put_page(page);
>> +
>> + rcu_read_lock();
>> + if (need_resched()) {
>> + xas_pause(&xas);
>> + cond_resched_rcu();
>> + }
>> + }
>> + rcu_read_unlock();
>> +
>> + return 0;
>
> I have a doubt on referencing xa_index after calling xas_pause().
> xas_pause() walks xa_index forward, so will not be the value expected
> for the current page.
Agree here. I should have the better test case to verify my changes.
> Also, not necessary to re-call xas_pause() before cond_resched (it is
> a no-op).
In the event when CONFIG_DEBUG_ATOMIC_SLEEP is enabled users may still
need to call the xas_pause(), as we are dropping the rcu lock. NO?
static inline void cond_resched_rcu(void)
{
#if defined(CONFIG_DEBUG_ATOMIC_SLEEP) || !defined(CONFIG_PREEMPT_RCU)
rcu_read_unlock();
cond_resched();
rcu_read_lock();
#endif
}
> Would be better to check need_resched() before
> rcu_read_lock().
Okay, I can directly use cond_resched() if used before rcu_read_lock().
>
> As this loop may call xas_pause() for most iterations, should consider
> using xa_for_each() instead (I *think* - still getting up to speed
> with XArray).
Even the xarray documentation says that: If most entries found during a
walk require you to call xas_pause(), the xa_for_each() iterator may be
more appropriate.
Since every value entry found in the xarray requires me to do the
xas_pause(), I do agree that xa_for_each() is the appropriate call here.
Will switch to this in the next spin. Waiting for further review
comments on this patch.
>
> Mark
>
next prev parent reply other threads:[~2022-01-10 10:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 17:05 [PATCH v3 RESEND] mm: shmem: implement POSIX_FADV_[WILL|DONT]NEED for shmem Charan Teja Reddy
2022-01-07 12:10 ` Mark Hemment
2022-01-10 10:21 ` Charan Teja Kalla [this message]
2022-01-12 8:21 ` Charan Teja Kalla
2022-01-12 11:34 ` Mark Hemment
2022-01-12 13:19 ` Matthew Wilcox
2022-01-12 13:35 ` Charan Teja Kalla
2022-01-18 11:35 ` Charan Teja Kalla
2022-01-18 13:27 ` Matthew Wilcox
2022-01-10 12:36 ` Mark Hemment
2022-01-10 15:14 ` Charan Teja Kalla
2022-01-12 11:38 ` Mark Hemment
2022-01-12 15:43 ` Charan Teja Kalla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c66ba2e-1c65-3bdd-b91e-eb8391ec6dbf@quicinc.com \
--to=quic_charante@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=charante@codeaurora.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markhemm@googlemail.com \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).