From: Suman Anna <s-anna@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Eric Auger <eric.auger@redhat.com>,
Douglas Anderson <dianders@chromium.org>,
Tero Kristo <t-kristo@ti.com>, <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] iommu: omap: Fix printing format for size_t on 64-bit
Date: Thu, 2 Jan 2020 16:30:42 -0600 [thread overview]
Message-ID: <2c797855-1967-007e-bbbc-e9f414fc9887@ti.com> (raw)
In-Reply-To: <20191230172619.17814-2-krzk@kernel.org>
On 12/30/19 11:26 AM, Krzysztof Kozlowski wrote:
> Print size_t as %zu or %zx to fix -Wformat warnings when compiling on
> 64-bit platform (e.g. with COMPILE_TEST):
>
> drivers/iommu/omap-iommu.c: In function ‘flush_iotlb_page’:
> drivers/iommu/omap-iommu.c:437:47: warning:
> format ‘%x’ expects argument of type ‘unsigned int’,
> but argument 7 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
With "iommu/omap: ..." on the subject-line as per the current convention,
Acked-by: Suman Anna <s-anna@ti.com>
regards
Suman
> ---
> drivers/iommu/omap-iommu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index 50e8acf88ec4..887fefcb03b4 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -434,7 +434,7 @@ static void flush_iotlb_page(struct omap_iommu *obj, u32 da)
> bytes = iopgsz_to_bytes(cr.cam & 3);
>
> if ((start <= da) && (da < start + bytes)) {
> - dev_dbg(obj->dev, "%s: %08x<=%08x(%x)\n",
> + dev_dbg(obj->dev, "%s: %08x<=%08x(%zx)\n",
> __func__, start, da, bytes);
> iotlb_load_cr(obj, &cr);
> iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY);
> @@ -1352,11 +1352,11 @@ static int omap_iommu_map(struct iommu_domain *domain, unsigned long da,
>
> omap_pgsz = bytes_to_iopgsz(bytes);
> if (omap_pgsz < 0) {
> - dev_err(dev, "invalid size to map: %d\n", bytes);
> + dev_err(dev, "invalid size to map: %zu\n", bytes);
> return -EINVAL;
> }
>
> - dev_dbg(dev, "mapping da 0x%lx to pa %pa size 0x%x\n", da, &pa, bytes);
> + dev_dbg(dev, "mapping da 0x%lx to pa %pa size 0x%zx\n", da, &pa, bytes);
>
> iotlb_init_entry(&e, da, pa, omap_pgsz);
>
> @@ -1393,7 +1393,7 @@ static size_t omap_iommu_unmap(struct iommu_domain *domain, unsigned long da,
> size_t bytes = 0;
> int i;
>
> - dev_dbg(dev, "unmapping da 0x%lx size %u\n", da, size);
> + dev_dbg(dev, "unmapping da 0x%lx size %zu\n", da, size);
>
> iommu = omap_domain->iommus;
> for (i = 0; i < omap_domain->num_iommus; i++, iommu++) {
>
next prev parent reply other threads:[~2020-01-02 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 17:26 [PATCH 1/3] iommu: omap: Fix pointer cast -Wpointer-to-int-cast warnings on 64 bit Krzysztof Kozlowski
2019-12-30 17:26 ` [PATCH 2/3] iommu: omap: Fix printing format for size_t on 64-bit Krzysztof Kozlowski
2020-01-02 22:30 ` Suman Anna [this message]
2019-12-30 17:26 ` [PATCH 3/3] iommu: Enable compile testing for some of drivers Krzysztof Kozlowski
2019-12-31 1:08 ` kbuild test robot
2019-12-31 8:14 ` Krzysztof Kozlowski
2019-12-31 7:43 ` kbuild test robot
2019-12-31 8:07 ` Krzysztof Kozlowski
2020-01-02 22:40 ` Suman Anna
2020-01-03 8:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c797855-1967-007e-bbbc-e9f414fc9887@ti.com \
--to=s-anna@ti.com \
--cc=dianders@chromium.org \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).