From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C49C43382 for ; Mon, 24 Sep 2018 22:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4243F204EC for ; Mon, 24 Sep 2018 22:15:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4243F204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728794AbeIYEUK (ORCPT ); Tue, 25 Sep 2018 00:20:10 -0400 Received: from mga09.intel.com ([134.134.136.24]:19342 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728667AbeIYEUJ (ORCPT ); Tue, 25 Sep 2018 00:20:09 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 15:15:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,299,1534834800"; d="scan'208";a="86205099" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.151]) ([10.7.153.151]) by orsmga003.jf.intel.com with ESMTP; 24 Sep 2018 15:15:46 -0700 Subject: Re: [RFC PATCH i2c-next 1/2] dt-bindings: i2c: aspeed: Add 'idle-wait-timeout-ms' setting To: Wolfram Sang Cc: Brendan Higgins , Benjamin Herrenschmidt , Joel Stanley , Andrew Jeffery , linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jarkko Nikula , James Feist , Vernon Mauery References: <20180910214519.14126-1-jae.hyun.yoo@linux.intel.com> <20180910214519.14126-2-jae.hyun.yoo@linux.intel.com> <20180924215850.GD18592@kunai> From: Jae Hyun Yoo Message-ID: <2c8563fd-0641-5237-0026-f559c480ad91@linux.intel.com> Date: Mon, 24 Sep 2018 15:15:46 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180924215850.GD18592@kunai> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On 9/24/2018 2:58 PM, Wolfram Sang wrote: > On Tue, Sep 18, 2018 at 11:02:54AM -0700, Jae Hyun Yoo wrote: >> On 9/10/2018 2:45 PM, Jae Hyun Yoo wrote: >>> +- idle-wait-timeout-ms : bus idle waiting timeout in milliseconds when >>> + multi-master is set, defaults to 100 ms when not >>> + specified. >> >> Will change it to 'aspeed,idle-wait-timeout-ms' as it's a non standard >> property. > > No need. This binding is not a HW description, so not a DT property in > my book. I still don't understand: Your IP core in master mode does not > have a BUSY bit or similar which detects when a START was detected and > clears after a STOP? > Okay, I'll keep this property as it is then. Aspeed IP has the BUSY bit on the I2CD14 register and we are already using the bit in the current code for single-master use cases. Due to the bit doesn't cover well multi-master use cases so we need to improve the current busy checking logic using the 'Transfer Mode State Machine' bit fields on the same register through this patch set. Thanks for the review! Jae