From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 948C4C004C9 for ; Tue, 7 May 2019 16:29:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64C002053B for ; Tue, 7 May 2019 16:29:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="TsSFG712" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbfEGQ3N (ORCPT ); Tue, 7 May 2019 12:29:13 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:44722 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbfEGQ3N (ORCPT ); Tue, 7 May 2019 12:29:13 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x47GTA7X052626; Tue, 7 May 2019 11:29:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1557246550; bh=latJPCxVxOxnoJw3g8qf+igWGVV+JWgQnCwSGe3528U=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=TsSFG7123AzOLIdTitWrYvQq+NzgVdq6UmN7UBQpRzB1SPDXZpLnmL+C+TPbT7kYS NaDL7Gc6/5bA7+dOAtfuGxaQ/TmSrOBb5+Br5RpFWW305ZJUPKNRmUq+WbgUCsChV7 pxolKG/lrWp5j7Ybaf5HPF7lb0Cx9hhDf4XZvKuw= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x47GTAmW125852 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 7 May 2019 11:29:10 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 7 May 2019 11:29:10 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 7 May 2019 11:29:10 -0500 Received: from [10.250.139.87] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x47GT75O007955; Tue, 7 May 2019 11:29:08 -0500 Subject: Re: [PATCH 1/2] mmc: sdhci_am654: Fix minor phy configurations To: Adrian Hunter , Faiz Abbas , , CC: References: <20190425155727.20010-1-faiz_abbas@ti.com> <20190425155727.20010-2-faiz_abbas@ti.com> <8317e8a0-1b1f-4b0d-8a9b-2a6fdd0ab4e5@intel.com> From: Faiz Abbas Message-ID: <2c867970-1255-b11f-9edf-ff002b7cea58@ti.com> Date: Tue, 7 May 2019 21:59:06 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <8317e8a0-1b1f-4b0d-8a9b-2a6fdd0ab4e5@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Adrian, On 26/04/19 11:20 AM, Adrian Hunter wrote: > On 25/04/19 6:57 PM, Faiz Abbas wrote: >> Fix the following minor things: >> >> 1. Line wrapping with the regmap_*() functions is way more conservative >> than required by the 80 character rule. Expand the function calls out to >> use less number of lines. >> >> 2. Add an error message if the DLL fails to lock. > > Please make the white space changes a separate patch. > > Also I would prefer not to use "fix" in the subject unless the patch fixes > driver behaviour. > Ok. Two different patches. No "fix" in the subject. Sending v2. Thanks, Faiz