From: Kishon Vijay Abraham I <kishon@ti.com>
To: Wen Yang <wen.yang99@zte.com.cn>
Cc: <lorenzo.pieralisi@arm.com>, <bhelgaas@google.com>,
<gustavo.pimentel@synopsys.com>, <niklas.cassel@axis.com>,
<baijiaju1990@gmail.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <xue.zhihong@zte.com.cn>,
<wang.yi59@zte.com.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cyrille Pitchen <cyrille.pitchen@free-electrons.com>
Subject: Re: [PATCH] PCI: endpoint: functions: use memcpy_fromio()/memcpy_toio()
Date: Mon, 11 Feb 2019 17:05:07 +0530 [thread overview]
Message-ID: <2c8762eb-ea8e-7de4-cfd8-f3db2cec5d91@ti.com> (raw)
In-Reply-To: <1549875840-10582-1-git-send-email-wen.yang99@zte.com.cn>
On 11/02/19 2:34 PM, Wen Yang wrote:
> Use the IO memcpy() functions when copying from/to IO memory.
> These locations were found via sparse.
>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> Suggested-by: Kishon Vijay Abraham I <kishon@ti.com>
> CC: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> CC: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> CC: Niklas Cassel <niklas.cassel@axis.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Cyrille Pitchen <cyrille.pitchen@free-electrons.com>
> CC: linux-pci@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 3e86fa3..4bbd26e 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -175,7 +175,7 @@ static int pci_epf_test_read(struct pci_epf_test *epf_test)
> goto err_map_addr;
> }
>
> - memcpy(buf, src_addr, reg->size);
> + memcpy_fromio(buf, src_addr, reg->size);
>
> crc32 = crc32_le(~0, buf, reg->size);
> if (crc32 != reg->checksum)
> @@ -230,7 +230,7 @@ static int pci_epf_test_write(struct pci_epf_test *epf_test)
> get_random_bytes(buf, reg->size);
> reg->checksum = crc32_le(~0, buf, reg->size);
>
> - memcpy(dst_addr, buf, reg->size);
> + memcpy_toio(dst_addr, buf, reg->size);
>
> /*
> * wait 1ms inorder for the write to complete. Without this delay L3
>
next prev parent reply other threads:[~2019-02-11 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 9:04 [PATCH] PCI: endpoint: functions: use memcpy_fromio()/memcpy_toio() Wen Yang
2019-02-11 11:35 ` Kishon Vijay Abraham I [this message]
2019-02-11 16:19 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c8762eb-ea8e-7de4-cfd8-f3db2cec5d91@ti.com \
--to=kishon@ti.com \
--cc=baijiaju1990@gmail.com \
--cc=bhelgaas@google.com \
--cc=cyrille.pitchen@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=niklas.cassel@axis.com \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).