From: Alex Shi <alex.shi@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
"open list:LOCKING PRIMITIVES" <linux-kernel@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sebastian Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 1/3] rtmutex: update rt-mutex-design
Date: Mon, 24 Apr 2017 21:45:20 +0800 [thread overview]
Message-ID: <2c89542e-befa-6e0b-60b0-b700086d83c1@linaro.org> (raw)
In-Reply-To: <CANLsYkwKkfGCkygsrn=kNYyUpqboY2Pr9NSuS0t0B86tZu9ruQ@mail.gmail.com>
structure holds a pointer to the task, as well as the mutex that
>> - the task is blocked on. It also has the plist node structures to
>> - place the task in the waiter_list of a mutex as well as the
>> - pi_list of a mutex owner task (described below).
>> + the task is blocked on. It also has a rbtree node structures to
>
> Here I assume we are talking about struct rt_mutex_waiter[1]. If so I
> suggest to replace rbtree with rb_node.
They are the same thing here, rbtree node and rb_node. :)
>
>> + place the task in waiters rbtree of a mutex as well as the
>> + pi_waiters rbtree of a mutex owner task (described below).
>
> Also following the comment for @pi_tree_entry, s/"a mutex owner
> task"/"a mutex owner waiters tree" .
As my understand, pi_waiters is in task structure. We refer to what's
the pi_tree_entry in.
>
> [1]. http://lxr.free-electrons.com/source/kernel/locking/rtmutex_common.h#L25
>
>
>> -
>> +If the G process has highest priority in the chain, then all the tasks up
>
> If process G has the highest priority in the chain, ...
Sounds better. Thanks!
>> +mutex (waiter "task" field is not NULL), then we go to sleep (call schedule)
>> +
>
> This change was likely not done on purpose.
Yes. Thanks.
>
prev parent reply other threads:[~2017-04-24 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 14:12 [PATCH v2 1/3] rtmutex: update rt-mutex-design Alex Shi
2017-04-21 14:12 ` [PATCH v2 2/3] rtmutex: update rt-mutex Alex Shi
2017-04-21 14:12 ` [PATCH v2 3/3] rtmutex: remove unnecessary adjust prio Alex Shi
2017-04-21 15:47 ` [PATCH v2 1/3] rtmutex: update rt-mutex-design Peter Zijlstra
2017-04-24 13:39 ` Alex Shi
2017-04-21 15:57 ` Mathieu Poirier
2017-04-24 13:45 ` Alex Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c89542e-befa-6e0b-60b0-b700086d83c1@linaro.org \
--to=alex.shi@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).