From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Melody Olvera <quic_molvera@quicinc.com>,
Stephen Boyd <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Marc Zyngier <maz@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Taniya Das <quic_tdas@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clock bindings
Date: Thu, 27 Oct 2022 17:59:28 -0400 [thread overview]
Message-ID: <2c8c4642-8aee-3da3-7698-5e08b4c5894d@linaro.org> (raw)
In-Reply-To: <a5e8c70a-3358-513b-c8a5-7a7903f6ea42@quicinc.com>
On 27/10/2022 17:28, Melody Olvera wrote:
>>>>> + - description: Board XO source
>>>>> + - description: Sleep clock source
>>>>> + - description: PCIE 0 Pipe clock source
>>>>> + - description: PCIE 0 Phy Auxiliary clock source
>>>>> + - description: USB3 Phy wrapper pipe clock source
>>>>> + minItems: 2
>>>> Why the clocks are optional?
>>> They should not be optional. They're always there.
>> Just to be sure - I refer to last three clocks here as indicated by
>> minItems:2.
>>
>> DTS does not define them, so something here is not complete or correct.
>>
> DT is incomplete; I don't have that in my current patchset. Will add later when PCIE and
> USB nodes are complete.
Bindings should be complete as much as possible, therefore please define
in the DTS stub clocks (fixed clocks) to fill these with a TODO notes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-27 21:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 19:04 [PATCH v3 0/5] clk: qcom: Add clocks for the QDU1000 and QRU1000 SoCs Melody Olvera
2022-10-26 19:04 ` [PATCH v3 1/5] dt-bindings: clock: Add QDU1000 and QRU1000 GCC clock bindings Melody Olvera
2022-10-27 15:54 ` Krzysztof Kozlowski
2022-10-27 18:24 ` Stephen Boyd
2022-10-27 19:35 ` Krzysztof Kozlowski
2022-10-27 21:28 ` Melody Olvera
2022-10-27 21:59 ` Krzysztof Kozlowski [this message]
2022-11-07 17:25 ` Bjorn Andersson
2022-11-07 23:03 ` Melody Olvera
2022-10-26 19:04 ` [PATCH v3 2/5] dt-bindings: clock: Add RPMHCC bindings for QDU1000 and QRU1000 Melody Olvera
2022-10-27 15:57 ` Krzysztof Kozlowski
2022-10-28 1:04 ` Melody Olvera
2022-10-28 1:09 ` Krzysztof Kozlowski
2022-10-28 16:54 ` Melody Olvera
2022-11-07 17:36 ` Bjorn Andersson
2022-10-26 19:04 ` [PATCH v3 3/5] clk: qcom: Add QDU1000 and QRU1000 GCC support Melody Olvera
2022-11-07 17:32 ` Bjorn Andersson
2022-11-07 23:19 ` Melody Olvera
2022-10-26 19:04 ` [PATCH v3 4/5] clk: qcom: Add support for QDU1000 and QRU1000 RPMh clocks Melody Olvera
2022-10-26 19:04 ` [PATCH v3 5/5] dt-bindings: qcom,pdc: Introduce pdc bindings for QDU1000 and QRU1000 Melody Olvera
2022-10-27 15:58 ` Krzysztof Kozlowski
2022-10-27 18:22 ` Stephen Boyd
2022-10-27 21:31 ` Melody Olvera
2022-10-27 21:38 ` Stephen Boyd
2022-11-07 17:16 ` Bjorn Andersson
2022-11-07 23:20 ` Melody Olvera
2022-11-08 1:27 ` (subset) [PATCH v3 0/5] clk: qcom: Add clocks for the QDU1000 and QRU1000 SoCs Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c8c4642-8aee-3da3-7698-5e08b4c5894d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).