From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932240AbdDSAxI (ORCPT ); Tue, 18 Apr 2017 20:53:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:11773 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdDSAxG (ORCPT ); Tue, 18 Apr 2017 20:53:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,219,1488873600"; d="scan'208";a="91474766" Subject: Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com, linuxppc-dev@lists.ozlabs.org References: <1491949266-6835-1-git-send-email-yao.jin@linux.intel.com> <1491949266-6835-5-git-send-email-yao.jin@linux.intel.com> <20170418185331.GC15584@krava> From: "Jin, Yao" Message-ID: <2cc8fa33-f0f8-d202-f663-d3b6cfef43d0@linux.intel.com> Date: Wed, 19 Apr 2017 08:53:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170418185331.GC15584@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/19/2017 2:53 AM, Jiri Olsa wrote: > On Wed, Apr 12, 2017 at 06:21:05AM +0800, Jin Yao wrote: > > SNIP > >> +const char *branch_type_name(int type) >> +{ >> + const char *branch_names[PERF_BR_MAX] = { >> + "N/A", >> + "JCC", >> + "JMP", >> + "IND_JMP", >> + "CALL", >> + "IND_CALL", >> + "RET", >> + "SYSCALL", >> + "SYSRET", >> + "IRQ", >> + "INT", >> + "IRET", >> + "FAR_BRANCH", >> + }; >> + >> + if ((type >= 0) && (type < PERF_BR_MAX)) >> + return branch_names[type]; >> + >> + return NULL; > looks like we should add util/branch.c with above functions > and merge it with util/parse-branch-options.c > > we create new file even for less code ;-) > > thanks, > jirka Could we directly add branch_type_name() in util/parse-branch-options.c? I just feel it's a bit waste of creating a new file for less code. :) Thanks Jin Yao