From: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
To: Joe Perches <joe@perches.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer
Date: Sat, 30 Jul 2016 10:26:31 +0200 [thread overview]
Message-ID: <2ccb1bd7-6a2a-d7d1-e768-82e25f156c71@m4x.org> (raw)
In-Reply-To: <1469821991.3998.86.camel@perches.com>
On 07/29/2016 09:53 PM, Joe Perches wrote:
> On Fri, 2016-07-29 at 13:10 +0200, Nicolas Iooss wrote:
>> handle_object_size_mismatch() used %pk to format a kernel pointer in
>> pr_err(). This seems to be a misspelling for %pK.
>
> Thanks
Thanks for your feedbacks. I agree %pK does not make much sense in the
context it is used. I will modify this patch to use %p instead.
>> diff --git a/lib/ubsan.c b/lib/ubsan.c
> []
>> @@ -308,7 +308,7 @@ static void handle_object_size_mismatch(struct
>> type_mismatch_data *data,
>> return;
>>
>> ubsan_prologue(&data->location, &flags);
>> - pr_err("%s address %pk with insufficient space\n",
>> + pr_err("%s address %pK with insufficient space\n",
>> type_check_kinds[data->type_check_kind],
>> (void *) ptr);
>> pr_err("for an object of type %s\n", data->type->type_name);
>
> Maybe change this to a single output line:
>
> pr_err("%s address %pK with insufficient space for an object of type %s\n",
> type_check_kinds[data->type_check_kind], (void *)ptr,
> data->type->type_name);
As both handle_missaligned_access() and handle_object_size_mismatch()
use two pr_err() calls to display their error messages, it seems the
split has been made on purpose (maybe to avoid logging long lines).
I won't merge the calls in my patch as this appears to be more an
ergonomic subject for people really using this code.
-- Nicolas
next prev parent reply other threads:[~2016-07-30 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 11:10 [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer Nicolas Iooss
2016-07-29 13:07 ` Andrey Ryabinin
2016-07-29 19:53 ` Joe Perches
2016-07-30 8:26 ` Nicolas Iooss [this message]
2016-07-30 8:30 ` [PATCH 1/1] UBSAN: fix typo in format string Nicolas Iooss
2016-08-01 11:47 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ccb1bd7-6a2a-d7d1-e768-82e25f156c71@m4x.org \
--to=nicolas.iooss_linux@m4x.org \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).