linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Coywolf Qi Hunt <coywolf@gmail.com>
To: Robert Love <rml@novell.com>
Cc: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	John McCutchan <ttb@tentacle.dhs.org>
Subject: Re: [patch] inotify.
Date: Tue, 10 May 2005 01:43:50 +0800	[thread overview]
Message-ID: <2cd57c90050509104363efed0e@mail.gmail.com> (raw)
In-Reply-To: <1115654707.6734.134.camel@betsy>

On 5/10/05, Robert Love <rml@novell.com> wrote:
> Below is the latest revision of inotify, against 2.6.12-rc4.
> 
> The only functional changes from the last release is a compile warning
> fix for !CONFIG_INOTIFY.

Here's another compile warning, also in the current -mm tree.

> diff -urN linux-2.6.12-rc4/fs/namei.c linux/fs/namei.c
> --- linux-2.6.12-rc4/fs/namei.c 2005-05-09 11:52:48.000000000 -0400
> +++ linux/fs/namei.c    2005-05-09 11:58:52.000000000 -0400

...

> @@ -2172,18 +2174,18 @@
>         DQUOT_INIT(old_dir);
>         DQUOT_INIT(new_dir);
> 
> +       old_name = fsnotify_oldname_init(old_dentry->d_name.name);
> +

prodigy:/home/coywolf/2.6.12-rc3-mm3-cy# make fs/namei.o
  CC      fs/namei.o
/home/coywolf/2.6.12-rc3-mm3-cy/fs/namei.c: In function `vfs_rename':
/home/coywolf/2.6.12-rc3-mm3-cy/fs/namei.c:2177: warning: passing arg
1 of `fsnotify_oldname_init' from incompatible pointer type


The problem lies in const char *name V.S. const unsigned char *name.


-- 
Coywolf Qi Hunt
http://sosdg.org/~coywolf/

  reply	other threads:[~2005-05-09 17:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-09 16:05 [patch] inotify Robert Love
2005-05-09 17:43 ` Coywolf Qi Hunt [this message]
2005-05-09 17:56   ` [patch] updated inotify Robert Love
2005-05-09 18:56     ` Coywolf Qi Hunt
2005-05-09 18:58       ` Robert Love
  -- strict thread matches above, loose matches on Subject: below --
2005-06-15 17:18 [patch] inotify Robert Love
2005-06-16 17:52 ` Zach Brown
2005-06-16 18:25   ` Robert Love
2005-06-17  1:30     ` Nick Piggin
2005-06-17  1:35       ` Robert Love
2005-06-17 17:07     ` Arnd Bergmann
2005-06-17 17:54       ` Christoph Hellwig
2005-06-17 18:12         ` John McCutchan
2005-06-17 18:16         ` Robert Love
2005-06-17 18:28           ` Christoph Hellwig
2005-06-17 18:38             ` Robert Love
2005-06-17 18:45               ` Christoph Hellwig
2005-06-17 18:54                 ` Robert Love
2005-06-17 17:56       ` John McCutchan
2005-06-17 21:33         ` Andrew Morton
2005-06-17 21:40           ` Robert Love
2005-06-17 23:52             ` Robert Love
2005-06-21  0:51               ` Neil Brown
2005-06-21  2:15                 ` John McCutchan
2005-06-21  2:29                   ` Neil Brown
2005-06-21  2:43                     ` John McCutchan
2005-06-21 15:55                     ` Robert Love
2005-07-14  0:25                       ` Neil Brown
2005-07-14  4:11                         ` John McCutchan
2005-06-18  0:05             ` Arnd Bergmann
2005-06-18  0:57               ` Robert Love
2005-06-18  1:51       ` Chris Wedgwood
2005-01-06 20:00 Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cd57c90050509104363efed0e@mail.gmail.com \
    --to=coywolf@gmail.com \
    --cc=akpm@osdl.org \
    --cc=coywolf@lovecn.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rml@novell.com \
    --cc=ttb@tentacle.dhs.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).