From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: <ebiederm@xmission.com>, <oleg@redhat.com>, <tj@kernel.org>,
<guro@fb.com>, <joel@joelfernandes.org>, <jannh@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mingfangsen <mingfangsen@huawei.com>,
Yanxiaodan <yanxiaodan@huawei.com>,
linfeilong <linfeilong@huawei.com>
Subject: Re: [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio
Date: Thu, 9 Apr 2020 11:26:08 +0800 [thread overview]
Message-ID: <2d00096f-94f7-753e-c05f-14860fed2abe@huawei.com> (raw)
In-Reply-To: <20200330084415.p4v5g6s24innsjrc@wittgenstein>
Friendly ping...
On 2020/3/30 16:44, Christian Brauner wrote:
> On Mon, Mar 30, 2020 at 10:18:33AM +0800, Zhiqiang Liu wrote:
>>
>> In kill_pid_usb_asyncio, if signal is not valid, we do not need to
>> set info struct.
>>
>> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>
> I'd have done:
>
> if (!valid_signal(sig))
> return -EINVAL;
>
> instead of setting ret to EINVAL above but that's mostly a matter of style.
>
> Picking this up unless someone sees a problem with it.
>
> Thank you!
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
>
> .
>
next prev parent reply other threads:[~2020-04-09 3:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 2:18 [PATCH] signal: check sig before setting info in kill_pid_usb_asyncio Zhiqiang Liu
2020-03-30 8:44 ` Christian Brauner
2020-04-09 3:26 ` Zhiqiang Liu [this message]
2020-04-09 6:53 ` Christian Brauner
2020-04-09 8:41 ` Zhiqiang Liu
2020-04-12 20:59 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d00096f-94f7-753e-c05f-14860fed2abe@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=guro@fb.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingfangsen@huawei.com \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
--cc=yanxiaodan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).