From: Michael Straube <straube.linux@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net,
phil@philpotter.co.uk, martin@kaiser.cx, fmdefrancesco@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] staging: r8188eu: remove dead code from rtl8188e_rf6052.c
Date: Thu, 23 Sep 2021 10:21:34 +0200 [thread overview]
Message-ID: <2d2b1e72-9c74-a2c3-2fb7-dc0ec41bbe03@gmail.com> (raw)
In-Reply-To: <20210923072929.GA2048@kadam>
On 9/23/21 09:29, Dan Carpenter wrote:
> On Tue, Sep 21, 2021 at 09:46:56PM +0200, Michael Straube wrote:
>> In this driver DynamicTxHighPowerLvl is set to TxHighPwrLevel_Normal
>> and never changed. In the file rtl8188e_rf6052.c there are some if
>> statements that check DynamicTxHighPowerLvl for other values than
>> TxHighPwrLevel_Normal. The code in the if blocks is never executed.
>> Remove the dead code.
>>
>> Signed-off-by: Michael Straube <straube.linux@gmail.com>
>> ---
>> drivers/staging/r8188eu/hal/rtl8188e_rf6052.c | 57 +++++--------------
>> 1 file changed, 14 insertions(+), 43 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
>> index edaa9a6dfdb1..946a1b97d96f 100644
>> --- a/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
>> +++ b/drivers/staging/r8188eu/hal/rtl8188e_rf6052.c
>> @@ -85,7 +85,6 @@ rtl8188e_PHY_RF6052SetCckTxPower(
>> u8 *pPowerlevel)
>> {
>> struct hal_data_8188e *pHalData = GET_HAL_DATA(Adapter);
>> - struct dm_priv *pdmpriv = &pHalData->dmpriv;
>> struct mlme_ext_priv *pmlmeext = &Adapter->mlmeextpriv;
>> u32 TxAGC[2] = {0, 0}, tmpval = 0, pwrtrac_value;
>> bool TurboScanOff = false;
>> @@ -112,34 +111,19 @@ rtl8188e_PHY_RF6052SetCckTxPower(
>> }
>> }
>> } else {
>> - /* Driver dynamic Tx power shall not affect Tx power.
>> - * It shall be determined by power training mechanism.
>> -i * Currently, we cannot fully disable driver dynamic
> ^
>
> You're a vimster. :)
>
Not really, actually this was part of the original code. ;)
Regards,
Michael
next prev parent reply other threads:[~2021-09-23 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 19:46 [PATCH 0/8] staging: r8188eu: remove dead dynamic tx power code Michael Straube
2021-09-21 19:46 ` [PATCH 1/8] staging: r8188eu: remove odm_DynamicTxPowerNIC() Michael Straube
2021-09-21 19:46 ` [PATCH 2/8] staging: r8188eu: remove odm_DynamicTxPowerAP() Michael Straube
2021-09-21 19:46 ` [PATCH 3/8] staging: r8188eu: remove odm_DynamicTxPower() Michael Straube
2021-09-21 19:46 ` [PATCH 4/8] staging: r8188eu: remove write-only fields from struct dm_priv Michael Straube
2021-09-21 19:46 ` [PATCH 5/8] staging: r8188eu: remove PowerIndex_backup " Michael Straube
2021-09-21 19:46 ` [PATCH 6/8] staging: r8188eu: remove dead code from rtl8188e_rf6052.c Michael Straube
2021-09-23 7:29 ` Dan Carpenter
2021-09-23 8:21 ` Michael Straube [this message]
2021-09-23 8:31 ` Dan Carpenter
2021-09-21 19:46 ` [PATCH 7/8] staging: r8188eu: remove DynamicTxHighPowerLvl from struct dm_priv Michael Straube
2021-09-21 19:46 ` [PATCH 8/8] staging: r8188eu: remove odm_DynamicTxPowerInit() Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d2b1e72-9c74-a2c3-2fb7-dc0ec41bbe03@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).