From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org
Cc: Benson Leung <bleung@chromium.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/chrome: chromeos_laptop: make I2C API conversion complete
Date: Mon, 30 Mar 2020 16:11:06 +0200 [thread overview]
Message-ID: <2d4269eb-0f17-47c8-d393-a3887a72526e@collabora.com> (raw)
In-Reply-To: <20200326210952.12857-2-wsa+renesas@sang-engineering.com>
Hi Wolfram,
On 26/3/20 22:09, Wolfram Sang wrote:
> When converting to i2c_new_scanned_device(), it was overlooked that a
> conversion to i2c_new_client_device() was also needed. Fix it.
>
> Fixes: c82ebf1bf738 ("platform/chrome: chromeos_laptop: Convert to i2c_new_scanned_device")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/platform/chrome/chromeos_laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/chromeos_laptop.c b/drivers/platform/chrome/chromeos_laptop.c
> index 4f3651fcd9fe..472a03daa869 100644
> --- a/drivers/platform/chrome/chromeos_laptop.c
> +++ b/drivers/platform/chrome/chromeos_laptop.c
> @@ -103,7 +103,7 @@ chromes_laptop_instantiate_i2c_device(struct i2c_adapter *adapter,
> pr_debug("%d-%02x is probed at %02x\n",
> adapter->nr, info->addr, dummy->addr);
> i2c_unregister_device(dummy);
> - client = i2c_new_device(adapter, info);
> + client = i2c_new_client_device(adapter, info);
> }
> }
>
>
Queued for 5.7.
Thanks.
Enric
next prev parent reply other threads:[~2020-03-30 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 21:09 [PATCH 0/2] platform: convert to use new I2C API Wolfram Sang
2020-03-26 21:09 ` [PATCH 1/2] platform/chrome: chromeos_laptop: make I2C API conversion complete Wolfram Sang
2020-03-30 14:11 ` Enric Balletbo i Serra [this message]
2020-03-26 21:09 ` [PATCH 2/2] platform/mellanox: mlxreg-hotplug: convert to use i2c_new_client_device() Wolfram Sang
2020-03-27 7:38 ` Andy Shevchenko
2020-04-25 20:54 ` Wolfram Sang
2020-04-26 8:34 ` Andy Shevchenko
2020-04-26 8:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d4269eb-0f17-47c8-d393-a3887a72526e@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).