* [PATCH v3] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3
@ 2022-05-04 17:21 Felix Fietkau
2022-05-05 8:27 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 2+ messages in thread
From: Felix Fietkau @ 2022-05-04 17:21 UTC (permalink / raw)
To: Ryder Lee, Jianjun Wang, Lorenzo Pieralisi, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, Matthias Brugger
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel
driver_register() will refuse to register another driver with the same name.
This change allows pcie-mediatek-gen3 to coexist with pcie-mediatek built into
the kernel.
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
index 3e8d70bfabc6..2e665cd7e735 100644
--- a/drivers/pci/controller/pcie-mediatek-gen3.c
+++ b/drivers/pci/controller/pcie-mediatek-gen3.c
@@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver = {
.probe = mtk_pcie_probe,
.remove = mtk_pcie_remove,
.driver = {
- .name = "mtk-pcie",
+ .name = "mtk-pcie-gen3",
.of_match_table = mtk_pcie_of_match,
.pm = &mtk_pcie_pm_ops,
},
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3
2022-05-04 17:21 [PATCH v3] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3 Felix Fietkau
@ 2022-05-05 8:27 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-05 8:27 UTC (permalink / raw)
To: Felix Fietkau, Ryder Lee, Jianjun Wang, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas,
Matthias Brugger
Cc: linux-pci, linux-mediatek, linux-kernel, linux-arm-kernel
Il 04/05/22 19:21, Felix Fietkau ha scritto:
> driver_register() will refuse to register another driver with the same name.
> This change allows pcie-mediatek-gen3 to coexist with pcie-mediatek built into
> the kernel.
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
> drivers/pci/controller/pcie-mediatek-gen3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
> index 3e8d70bfabc6..2e665cd7e735 100644
> --- a/drivers/pci/controller/pcie-mediatek-gen3.c
> +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
> @@ -1021,7 +1021,7 @@ static struct platform_driver mtk_pcie_driver = {
> .probe = mtk_pcie_probe,
> .remove = mtk_pcie_remove,
> .driver = {
> - .name = "mtk-pcie",
> + .name = "mtk-pcie-gen3",
> .of_match_table = mtk_pcie_of_match,
> .pm = &mtk_pcie_pm_ops,
> },
>
Hello Felix,
this is a good fix - and being it a fix, this requires a Fixes: tag - which also
gets this scheduled for backporting, which is important to solve this issue on
all of the affected kernels.
I'll make it easy for you as I've already checked the commit hash:
Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
After adding that:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cheers,
Angelo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-05 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-04 17:21 [PATCH v3] PCI: mediatek-gen3: Change driver name to mtk-pcie-gen3 Felix Fietkau
2022-05-05 8:27 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).