From: Paolo Bonzini <pbonzini@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Linux List Kernel Mailing" <linux-kernel@vger.kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"KVM list" <kvm@vger.kernel.org>
Subject: Re: [GIT PULL] KVM changes for Linux 5.2-rc2
Date: Sun, 26 May 2019 19:53:53 +0200 [thread overview]
Message-ID: <2d55fd2a-afbf-1b7c-ca82-8bffaa18e0d0@redhat.com> (raw)
In-Reply-To: <CAHk-=wi3YcO4JTpkeENETz3fqf3DeKc7-tvXwqPmVcq-pgKg5g@mail.gmail.com>
On 26/05/19 17:51, Linus Torvalds wrote:
> On Sun, May 26, 2019 at 2:56 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
>
> This says it's a tag, but it's not. It's just a commit pointer (also
> called a "lightweight tag", because while it technically is exactly
> the same thing as a branch, it's obviously in the tag namespace and
> git will _treat_ it like a tag).
>
> Normally your tags are proper signed tags. So I'm not pulling this,
> waiting for confirmation.
Shell history shows that I typed
git push kvm +HEAD:tags/for-linus
(which matches the "git push kvm +HEAD:queue" that I often do, and
therefore can be explained by muscle memory).
The interesting thing is that not only git will treat lightweight tags
like, well, tags: in addition, because I _locally_ had a tag object that
pointed to the same commit and had the same name, git-request-pull
included my local tag's message in its output! I wonder if this could
be considered a bug.
I have now pushed the actual tag object to the same place.
Paolo
next prev parent reply other threads:[~2019-05-26 17:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 9:55 [GIT PULL] KVM changes for Linux 5.2-rc2 Paolo Bonzini
2019-05-26 15:51 ` Linus Torvalds
2019-05-26 17:53 ` Paolo Bonzini [this message]
2019-05-26 20:49 ` Linus Torvalds
2019-05-26 22:54 ` [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/* Ævar Arnfjörð Bjarmason
2019-05-27 12:33 ` Paolo Bonzini
2019-05-27 14:29 ` Ævar Arnfjörð Bjarmason
2019-05-27 15:39 ` Junio C Hamano
2019-05-27 15:44 ` Paolo Bonzini
2019-06-21 14:44 ` [PATCH] push: make "HEAD:tags/my-tag" consistently push to a branch Ævar Arnfjörð Bjarmason
2019-06-21 16:05 ` Junio C Hamano
2019-05-26 20:55 ` [GIT PULL] KVM changes for Linux 5.2-rc2 pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d55fd2a-afbf-1b7c-ca82-8bffaa18e0d0@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).