From: Trond Myklebust <trondmy@hammerspace.com>
To: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"rmilkowski@gmail.com" <rmilkowski@gmail.com>
Cc: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NFSv4: nfs4_do_fsinfo() should not do implicit lease renewals
Date: Mon, 16 Dec 2019 18:58:19 +0000 [thread overview]
Message-ID: <2d94fa3e9632c638f9e47999fd8e26cb3b34b4dc.camel@hammerspace.com> (raw)
In-Reply-To: <05ea01d5b440$bd9d58d0$38d80a70$@gmail.com>
-On Mon, 2019-12-16 at 18:43 +0000, Robert Milkowski wrote:
> > From: Trond Myklebust <trondmy@hammerspace.com>
> ...
> > NACK. The above argument only applies to legacy minor version 0
> > setups, and does not apply to NFSv4.1 or newer.
>
> Correct. However many sites still use v4.0.
>
That's not a good reason to break code that works just fine for
NFSv4.1.
It would be better to move the initialisation of clp->cl_last_renewal
into nfs4_init_clientid() and nfs41_init_clientid() (after the calls to
nfs4_proc_setclientid_confirm() and nfs4_proc_create_session()
respectively).
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
next prev parent reply other threads:[~2019-12-16 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 17:38 [PATCH] NFSv4: nfs4_do_fsinfo() should not do implicit lease renewals Robert Milkowski
2019-12-16 18:24 ` Trond Myklebust
2019-12-16 18:43 ` Robert Milkowski
2019-12-16 18:58 ` Trond Myklebust [this message]
2019-12-17 18:12 ` Robert Milkowski
2019-12-18 14:48 ` Robert Milkowski
2019-12-16 18:58 ` Chuck Lever
2019-12-16 18:36 ` Robert Milkowski
2019-12-16 18:41 ` Robert Milkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d94fa3e9632c638f9e47999fd8e26cb3b34b4dc.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=rmilkowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).