From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756326AbcLTWO1 (ORCPT ); Tue, 20 Dec 2016 17:14:27 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:57345 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753370AbcLTWOX (ORCPT ); Tue, 20 Dec 2016 17:14:23 -0500 Subject: Re: [PATCH 3/8] block: move rq_ioc() to blk.h To: Paolo Valente References: <1481933536-12844-1-git-send-email-axboe@fb.com> <1481933536-12844-4-git-send-email-axboe@fb.com> <5A31E864-F10C-4CB4-B780-BB16524E3590@linaro.org> CC: , Linux-Kernal , From: Jens Axboe Message-ID: <2dc5af5b-1e0c-9b4b-5cc4-2bf8518a5e40@fb.com> Date: Tue, 20 Dec 2016 15:14:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: DM3PR14CA0050.namprd14.prod.outlook.com (10.166.156.146) To CY4PR15MB1192.namprd15.prod.outlook.com (10.172.177.14) X-MS-Office365-Filtering-Correlation-Id: 629123af-3469-43d7-93f2-08d429258b2a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;3:5k5JfPL47c3QrHeJEcnpCFSfCNq7yZP5NLSI2zdSQzFyzcMaTYnrKyam8VD30Ixb6+n6Yu9j0MQ2p2RidRbN8iJlLggBD6kHgwGeLoPyCkLSn4EYX3cLY/I90WZg5gep1olhHnmQJxw6cLeazJkAVnUwl8cW+KEJonfjX5sn5BVWKJUIJLkJ0O9BnLUuLt+h2AKOXAXJ70gjgzrWZBzRHG8QJegwUsEbgJEnfPdECV86EDAQghe5yblxkjFcuLI18Ayky/ckkr67ILXP1+AKPg==;25:W0eQNh/H6Q7kCV1XBE6iYNeURGOZfptONVCtUHqAsSSdpkyIcckSumTveWgAp48qo7o4De5+FdRx9OCNuVVtL7s2ZNpqADZwpqpcMrO/ppdSLrygkDSiaL3sD/JntdK1+7T+mdvdd3KiCyV20FTqj5txBtgT0rgoTDWRwD5vqpC2SkFx0kQPNyHeMZORl5TDrdEV/GKQd+DTBzzf+ssB1KlaeAotl2Ckg7DZfvJEioYRMLeZMCiQkp+61VrH71EOnQ3f7DGTgmKz9XIyGmnH1eYWw63go24Uyxf08Gapy+F78m6KatGO7fuhqVKeggYctGXWTNtRWjyoWkfge2cDIKfAORH0tNUWn/wk05nQHNFpxp77OGcfZDTOjCvC9m1RqKY4YDuB+DI6sb/0Xeij+1gJhJLZFrC1gkqOu2FgtG5WQrFVDmt9EvOdjCyKbzO79F+MG2Fvlqz4QHcpmW/kRw== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;31:al0XsuRi7xiQOvyq/nBP1P0Y7Q5aiKbrE6gapaedogGz5n1bdxw3dT2WzMB3Shp09oAI4wV69sE3jwGExCJKx/gBrb4dBNCS48kYqlkuboEwLiFbdVp2Htx75T+B0nB4Vn9IZZUKzazCJ1hbuXLIfdbBF8OP1uPyrnHCrY4Z7JFbukaKTrRxeRttsbFtkV+2meqGDLyPFd2DSc16yLbXRUJ2ol8InJFQ7cBuNiw094Pcu8FF3Kdi3g35T7UP1kzB;20:Jt5XJqZL6rX7yhLgr+fmgN2018JzWEhuSO1ZsdORRdXg+4PjvLhkbk+JKuUYUTsUW9wz99ryzpIpzDVMTjbSy5Ym+TwnFNAgnJVEs4vghFQqtMwpF8sDSAkvphi7E5SHO5LkDzaYAUYSrEmKj0dpR+x1LdKMiPRl0bPwELyJvLngallK3IJ3gD0Zc6i1Frem0goWnfrVS9OYHIBFwSocyfLKk11hqLZBKI/PespaloW0xE4Qbr24kH7uOreDhT+as/wYkRsNKZHW/78IJM0gtVXagWIoJZWHvpCLVzW/R8tZlSJUwjff05WhAZt2bVitWbO9SlkmNEeYXfMBqQhH5y2uuwcfJt2OH3fwWb7oF79CZgojMZVNus6n5uSTxfMuybDEyUYzh98KoE/H2KF8gBRJGKNUS7FMzLmUigIi1NDZkuCAUNnVrJ+aJyvqf5YmWpyullo3lMEPu9rHiaw2QZ/3uDi2gLK4rNyoGfcZ27g+igwTdjo2McivJIw+F97d X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(6072148);SRVR:CY4PR15MB1192;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1192; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;4:5qa9A1w3kwo+Rp89pqZw6eHb7qmx+dPEb5DkTLIC6sGhwL9w5Rr77LxYAcmYG2kWaOxMzkpOmtw1SvX10605swgKx1FPPqyOhX4RUbm1otkyvC+Od1evjgPgocnKdgzALIrdLNhgBNnIW+6ONsAaMF8u5HBpm2ENhouEZzwLg3r3ly/LumtGxTvYTa7iytXq02NIMZDaHCXvoArPecpJc6hP5FuLC+mc3EhoJiXMsa9NX5VCqE+dUo1gvgJ6vFqYC2mjziVjmSI0fKG3DPN0PUxcjWJXqK7CMZ1NVrdUp3yWTmxDg38E/JcMUa73Glc2sPxJ7dk27TAR4+4tFpW/yLy93dULKFWUkyQOd5mUzDZpvEX/seKtEdApuw2Zqh4IUsSKnmfCh3KsGZsElUMhWqrLwDdjvZfkcT7qAQHw9/dBI+eJqZbp7c3HWir2V1u476GixZNFq4XqaI2HZh33ETDlwuK0caiRqOExzAZx9WBBo9N3HnXwr//8hPePAADqRu+/K4/ocHLN9zKBXP8/MoT4JOqGrHZZ3L2b88aVFYwVlzlvFNPqtHrgnbDYVsz00HshNsMPGl+uC4C/18FUjH+QG21lxBu+DZegL6eBnw+EzTz8Nqjsp8CWJe+85ZHX X-Forefront-PRVS: 0162ACCC24 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39410400002)(39450400003)(39830400002)(24454002)(189002)(199003)(377454003)(230700001)(77096006)(90366009)(93886004)(97736004)(229853002)(81156014)(6916009)(50466002)(106356001)(81166006)(7736002)(305945005)(33646002)(4326007)(2950100002)(83506001)(2906002)(31696002)(64126003)(65956001)(92566002)(38730400001)(8676002)(66066001)(3846002)(117156001)(65806001)(6116002)(36756003)(25786008)(6486002)(47776003)(5660300001)(23746002)(31686004)(42186005)(65826007)(54356999)(76176999)(105586002)(86362001)(4001350100001)(6666003)(189998001)(50986999)(68736007)(110136003)(101416001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1192;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1192;23:vHKCCnFPLwLNLjlk38WUeKoLYIyds8zT3Dwa9?= =?Windows-1252?Q?8Q40ajsmzr/G84OHIYheAOLWVR4TzdqoCnF+/CTH2CoMHaQbEAZKDypr?= =?Windows-1252?Q?N0+WrTasHoWHFQYfzzfOxghP3fhqxHlDTMzUaztzeevg6qQj6BcqTslt?= =?Windows-1252?Q?jSc+A3QTeWuBrZgnLEOEh8qElzSVlK7qKnSKaxdEZo7O5QGzo/hf9hd3?= =?Windows-1252?Q?te5RF5ZNW/KymHrbw/9IdC6Yqle+Qz9ODKulF+GKN7mkERHGiaDfthFt?= =?Windows-1252?Q?FDzqY1H6iGjb82fR0CZmuKBQl+gfMsAb4vqVAkdbK/eiHsbGYX4arC0y?= =?Windows-1252?Q?HbIj29o2YvcSs6jsGdKR0PfCoxNi+3iTJc/IS8C9iJSZ9orCvEhgqcXB?= =?Windows-1252?Q?EvS0LG54FuaA/O7UB7U1ua220JowpEP4hrGxixrizqqYwLTeFRhHLVU6?= =?Windows-1252?Q?QW2M6tlUvDtwA9c4aeZ4M1QL/q8t9KvBgDGCM8u/4Ti4SRIAfFkRIob3?= =?Windows-1252?Q?qIb16AlG3y1K9okMpN8e1L+i7iY4rBCS/9r1QR1gbln/vfyzAdQOG5yC?= =?Windows-1252?Q?Irsb0f99jrnp6COeiW5jg5f7yGXYfqlSEV3uPns3p807nkaOeENGPypK?= =?Windows-1252?Q?z7+sOBCyk9xL8HySYFC2vRSFSZSGUZmzKgsdtLZNzGezj6IqKorX7Kvy?= =?Windows-1252?Q?IIWrkQhvVS9PE9YqnLVHCbrax1keOw8mWFl9DD0g+rt3iNcEbk2/ZvJD?= =?Windows-1252?Q?WEAl53YUSCegW18TQMFllwBcEEqXqSlA998rT9K2ZTDgaKC1AyEudVdt?= =?Windows-1252?Q?o3FQxWrUzwFGwA/FZqZ/bLmjMEd2q6Rq+JysbREAARYBN6jhclL+Y52N?= =?Windows-1252?Q?RccMobJePS9ccTe4prv5nU/B4T4B5V28qhhOlP2L76UlVz5uCexQUJwx?= =?Windows-1252?Q?3CQkR6sEa3Og5rwnUdE6LsEk8ShfH/XXEx8PKKQ6XkqkiIwzOPnM6+GL?= =?Windows-1252?Q?tgeIz+R+IEsi+AjiYzNmOIRsLZTy35nbeeVWbWbVokTd1SgX+WXQk3vD?= =?Windows-1252?Q?husDVPNExf8ZWpOZZQDSrlXDVcUW0LSOgFbml7Ny3l2f2o/EZ5MpwxIQ?= =?Windows-1252?Q?RmbyDND3tsIAkicDQx9QH/rhU9uZmc+WzBolNX2hYXYSBJCCquDvWHqW?= =?Windows-1252?Q?kUhE3lHLx7v3sdULHjgc1gDQrovoQ8vd0VDwNztiYv/9C20BsnATsJNM?= =?Windows-1252?Q?NJ2u8x/u411RC+IdswzVSNvnzMCNhTSRSaxP9dbJ9eI6CKgY4H0WUZuD?= =?Windows-1252?Q?l/ZUTt9vwKSlMvkfKVscv4iSSslJ9LPPaWnlODHEHtnAxapjOzeaVco3?= =?Windows-1252?Q?K4xSJ7E9nknUYQvhJqTeizXRncZq3O/R24sq4nqX4iUA2EUibf9PvXx2?= =?Windows-1252?Q?9kMsmbSyemZfgdiJl+T9K+x01DwqsNl4WcJab1GBGjJq6//gUMnlJjud?= =?Windows-1252?Q?0d7ER1hpJPWC28iMlZTbTg7ruDX9H+lGU5tSaxbKcjeWygo2hLKMd1N+?= =?Windows-1252?Q?3cm8jjWoPYKg8w=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;6:nDpGBaR9g78Dl+3VAa9Syn4DDSost3I60/VGJcCzBQ69UyPktj/jSgTCxL3AVwRQq5YV+uY36u++kMFy9X1jI30zBctHzEUCKonK1OWNI4PIEDDBoD02T8bqLa5xI/K39ckJY5gE7iOJ1fUwlQpvQoat+ykciT+gcWEztSbj5K39XIV6AT0XhMx+1c609TIoKZtCtRYwPXX1McHRajt6jTwpAkSQ6aaGh3CxMNoNI9Z+t8oBPKrdPg7am6sfA6uLQwXtqleRh9YlGUWjJG/pV6vNUKmSoxY3aWJJEt8reUHc5j+SIi5h3dainBEkBPXcUZeIvKW9Q12SqFlqsObgLIJZMEJbNWvbz/3Md1nhHHqcxqfqrVQZ1/7VyphLfT+JaitQCCpN9R0cxH3ba3YwDr9Dujhz/KUOuNS51GdNU/A=;5:MBX0F2cANghgRGB31H6+LEWO4hXYiOFvRNzFfAdgbpBXIk6XbfSLgnu4YhUDq9JuBlJ+9++wqTvsFdUVh1D0Yr6ybl8+EpummSnXEmTf3OFBiNSXpSlySaZY3GA+fKc830OZgfiL4BGqezDH/yoNJiYfnn2puUm0McfB5YeHLc4=;24:bwjBtqucyXBHq0AG1AqmmpQdzw1v3Xh1H428pED2oIUgAPenPrSs2VJ5S8bgTJ9Axx5pRjvfkYfCi1WEKr/mude0VTGFWEag15w4TjhIzjo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1192;7:X44j67hVp5pqXzIBC4WDYOCvdql7Y78mg/NSfHJSEbtYGcb8X0zwweZ/+ACNJdRYgz5pivNJOFbIOhZ2e/vV4XXDXIOojjeDDDRMZEzQ/bEYAsdmkw47AmRWOSAbjNs8g8XfEXmdmHM2TFRVfySKxfpIXF0fISieLj93UzBl7F+7DRzq+mSt7nSEs63WwAiaQK+pBLmivWVmbVOqK2Et1NqkKGO4CTr196QBqQ7WSD7JHWvGAA5bbgt5fl+yWJ/OFDqXQR9NKkRKNOMpos7zppeeuHky1Z+c+u/rNZEHqE8iosNrZXqJRzojiq0oUrscdBha8CcnMBtTnrt3L6rHwBUSpgZ6rjv0WSwGX40+AxznER7m0WuBukD8rqvBDWAeTfKdRehLK+GHCLzCEyI1ELOUFMoWGqtA2fYkBRVvwcoFpjj4/LzxTLiHJ0ziqszRwtCxxjtP5mqITsAIiw+GdQ==;20:EvOupU3CTPpRaqNel83kxIenukKH6XDR2LINj9v0S0MpDcMaAdU8vfYuhPmTmq5/5ke8CWRkzFzLj1DNRFHtPEOoXWhU3TMJUmIL7ZPrlFNMzL35p5OMHn+lKbZVob7qL+M5xH/YikQQg6IbIkEiMHY5prtBelf/su48JtRqO7g= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 22:14:17.5091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1192 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-20_16:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/20/2016 08:46 AM, Jens Axboe wrote: > On 12/20/2016 03:12 AM, Paolo Valente wrote: >> >>> Il giorno 17 dic 2016, alle ore 01:12, Jens Axboe ha scritto: >>> >>> We want to use it outside of blk-core.c. >>> >> >> Hi Jens, >> no hooks equivalent to elevator_init_icq_fn and elevator_exit_icq_fn >> are invoked. In particular, the second hook let bfq (as with cfq) >> know when it could finally exit the queue associated with the icq. >> I'm trying to figure out how to make it without these hooks/signals, >> but at no avail so far ... > > Yep, those need to be added. Done, pushed out. -- Jens Axboe