From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: dspmihai <despotovici.mihai@gmail.com>, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: spear: Remove redundant message
Date: Sun, 26 Feb 2017 17:05:02 +0900 [thread overview]
Message-ID: <2dcacbcf-c4b1-fd44-90ca-a15c47980657@sakamocchi.jp> (raw)
In-Reply-To: <1488018810-11973-1-git-send-email-despotovici.mihai@gmail.com>
On Feb 25 2017 19:33, dspmihai wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Despotovici Mihai <despotovici.mihai@gmail.com>
> ---
> sound/soc/spear/spdif_in.c | 4 +---
> sound/soc/spear/spdif_out.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/spear/spdif_in.c b/sound/soc/spear/spdif_in.c
> index 977a078..0f3b1a8 100644
> --- a/sound/soc/spear/spdif_in.c
> +++ b/sound/soc/spear/spdif_in.c
> @@ -216,10 +216,8 @@ static int spdif_in_probe(struct platform_device *pdev)
> return -EINVAL;
>
> host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - dev_warn(&pdev->dev, "kzalloc fail\n");
> + if (!host)
The line for dev_warn() should be kept.
> return -ENOMEM;
> - }
>
> host->io_base = io_base;
> host->irq = platform_get_irq(pdev, 0);
> diff --git a/sound/soc/spear/spdif_out.c b/sound/soc/spear/spdif_out.c
> index 0a72d52..58d5843 100644
> --- a/sound/soc/spear/spdif_out.c
> +++ b/sound/soc/spear/spdif_out.c
> @@ -282,10 +282,8 @@ static int spdif_out_probe(struct platform_device *pdev)
> int ret;
>
> host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - dev_warn(&pdev->dev, "kzalloc fail\n");
> + if (!host)
Ditto.
> return -ENOMEM;
> - }
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> host->io_base = devm_ioremap_resource(&pdev->dev, res);
Takashi Sakamoto
next prev parent reply other threads:[~2017-02-26 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 10:33 [PATCH] ASoC: spear: Remove redundant message dspmihai
2017-02-26 8:05 ` Takashi Sakamoto [this message]
2017-08-10 15:42 ` Applied "ASoC: spear: Delete an error message for a failed memory allocation in two functions" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dcacbcf-c4b1-fd44-90ca-a15c47980657@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=despotovici.mihai@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).