From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EEAC4332F for ; Wed, 23 Nov 2022 15:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238280AbiKWP74 (ORCPT ); Wed, 23 Nov 2022 10:59:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237787AbiKWP7g (ORCPT ); Wed, 23 Nov 2022 10:59:36 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9B8B1A19E for ; Wed, 23 Nov 2022 07:59:35 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D72831FB; Wed, 23 Nov 2022 07:59:41 -0800 (PST) Received: from [10.57.87.10] (unknown [10.57.87.10]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC2823F73B; Wed, 23 Nov 2022 07:59:30 -0800 (PST) Message-ID: <2ddef062-2db4-974b-e856-58878b70856e@arm.com> Date: Wed, 23 Nov 2022 15:59:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v9 02/11] drm/panfrost: Don't sync rpm suspension after mmu flushing Content-Language: en-GB To: Dmitry Osipenko , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Sumit Semwal , =?UTF-8?Q?Christian_K=c3=b6nig?= , Qiang Yu , Alyssa Rosenzweig , Rob Herring , Sean Paul , Dmitry Baryshkov , Abhinav Kumar Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org References: <20221123025723.695075-1-dmitry.osipenko@collabora.com> <20221123025723.695075-3-dmitry.osipenko@collabora.com> From: Steven Price In-Reply-To: <20221123025723.695075-3-dmitry.osipenko@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/11/2022 02:57, Dmitry Osipenko wrote: > Lockdep warns about potential circular locking dependency of devfreq > with the fs_reclaim caused by immediate device suspension when mapping is > released by shrinker. Fix it by doing the suspension asynchronously. > > Signed-off-by: Dmitry Osipenko Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c > index e246d914e7f6..99a0975f6f03 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c > +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c > @@ -273,7 +273,7 @@ static void panfrost_mmu_flush_range(struct panfrost_device *pfdev, > if (pm_runtime_active(pfdev->dev)) > mmu_hw_do_operation(pfdev, mmu, iova, size, AS_COMMAND_FLUSH_PT); > > - pm_runtime_put_sync_autosuspend(pfdev->dev); > + pm_runtime_put_autosuspend(pfdev->dev); > } > > static int mmu_map_sg(struct panfrost_device *pfdev, struct panfrost_mmu *mmu,