From: Jiabing Wan <11126903@vivo.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Wan Jiabing <wanjiabing@vivo.com>, Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kael_w@yeah.net
Subject: Re: [PATCH] selftests: bpf: Remove duplicated include in cgroup_helpers
Date: Tue, 12 Oct 2021 10:20:44 +0800 [thread overview]
Message-ID: <2defbe3c-c26f-012d-8b98-115da74bf752@vivo.com> (raw)
In-Reply-To: <ALUAmAB4EgbN1cS90y4NDarn.9.1633962609302.Hmail.wanjiabing@vivo.com>
On 2021/10/11 22:30, Daniel Borkmann wrote:
> On 10/11/21 1:19 PM, Wan Jiabing wrote:
>> Fix following checkincludes.pl warning:
>> ./tools/testing/selftests/bpf/cgroup_helpers.c
>> 12 #include <unistd.h>
>> 14 #include <unistd.h>
>
> What does the 12 vs 14 mean here? Please provide a proper commit
> description, e.g. if
> you used checkincludes.pl, maybe include the full command invocation
> and the relevant
> output, so that this is more obvious and in a better shape. Thanks!
Sorry for my fuzzy description. 12 and 14 mean the line of includes file.
The script checkincludes.pl can only show which file is included
duplicated, like
./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
than once.
So I upgrade the script so it can tell me the position of the duplicated
includes.
I'll fix the description in v2.
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>> ---
>> tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c
>> b/tools/testing/selftests/bpf/cgroup_helpers.c
>> index 8fcd44841bb2..9d59c3990ca8 100644
>> --- a/tools/testing/selftests/bpf/cgroup_helpers.c
>> +++ b/tools/testing/selftests/bpf/cgroup_helpers.c
>> @@ -11,7 +11,6 @@
>> #include <fcntl.h>
>> #include <unistd.h>
>> #include <ftw.h>
>> -#include <unistd.h>
>> #include "cgroup_helpers.h"
>>
>
prev parent reply other threads:[~2021-10-12 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 11:19 [PATCH] selftests: bpf: Remove dumplicated include in cgroup_helpers Wan Jiabing
2021-10-11 14:30 ` Daniel Borkmann
[not found] ` <ALUAmAB4EgbN1cS90y4NDarn.9.1633962609302.Hmail.wanjiabing@vivo.com>
2021-10-12 2:20 ` Jiabing Wan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2defbe3c-c26f-012d-8b98-115da74bf752@vivo.com \
--to=11126903@vivo.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kael_w@yeah.net \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=wanjiabing@vivo.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).