From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752932AbeACOT6 (ORCPT + 1 other); Wed, 3 Jan 2018 09:19:58 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57388 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750857AbeACOT4 (ORCPT ); Wed, 3 Jan 2018 09:19:56 -0500 Subject: Re: [PATCH 2/3] mm, migrate: remove reason argument from new_page_t To: Michal Hocko , Anshuman Khandual References: <20180103082555.14592-1-mhocko@kernel.org> <20180103082555.14592-3-mhocko@kernel.org> <20180103140923.GD11319@dhcp22.suse.cz> Cc: Andrew Morton , Zi Yan , Naoya Horiguchi , "Kirill A. Shutemov" , Vlastimil Babka , Andrea Reale , linux-mm@kvack.org, LKML From: Anshuman Khandual Date: Wed, 3 Jan 2018 19:49:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20180103140923.GD11319@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18010314-0020-0000-0000-000003E630AD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18010314-0021-0000-0000-000042783FCC Message-Id: <2dff7c5e-118b-1e57-ef13-2fa7389895fd@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-03_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1801030202 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/03/2018 07:39 PM, Michal Hocko wrote: > On Wed 03-01-18 19:30:38, Anshuman Khandual wrote: >> On 01/03/2018 01:55 PM, Michal Hocko wrote: >>> From: Michal Hocko >>> >>> No allocation callback is using this argument anymore. new_page_node >>> used to use this parameter to convey node_id resp. migration error >>> up to move_pages code (do_move_page_to_node_array). The error status >>> never made it into the final status field and we have a better way >>> to communicate node id to the status field now. All other allocation >>> callbacks simply ignored the argument so we can drop it finally. >> >> There is a migrate_pages() call in powerpc which needs to be changed >> as well. It was failing the build on powerpc. > > Yes, see http://lkml.kernel.org/r/20180103091134.GB11319@dhcp22.suse.cz Oops, my bad. I am sorry, missed this.