From: Joe Perches <joe@perches.com> To: Linus Torvalds <torvalds@linux-foundation.org>, Vlad Yasevich <vyasevich@gmail.com>, Neil Horman <nhorman@tuxdriver.com>, Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>, Kees Cook <keescook@chromium.org>, Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>, Pavel Machek <pavel@ucw.cz>, "Gustavo A . R . Silva" <gustavo@embeddedor.com>, Arnaldo Carvalho de Melo <acme@kernel.org>, Kan Liang <kan.liang@linux.intel.com>, Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Shawn Landden <shawn@git.icu>, x86@kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor <natechancellor@gmail.com>, Nick Desaulniers <ndesaulniers@google.com>, Andrew Morton <akpm@linux-foundation.org>, David Miller <davem@davemloft.net>, clang-built-linux@googlegroups.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 1/4] net: sctp: Rename fallthrough label to unhandled Date: Sat, 5 Oct 2019 09:46:41 -0700 [thread overview] Message-ID: <2e0111756153d81d77248bc8356bac78925923dc.1570292505.git.joe@perches.com> (raw) In-Reply-To: <cover.1570292505.git.joe@perches.com> fallthrough may become a pseudo reserved keyword so this only use of fallthrough is better renamed to allow it. Signed-off-by: Joe Perches <joe@perches.com> --- net/sctp/sm_make_chunk.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index e41ed2e0ae7d..48d63956a68c 100644 --- a/net/sctp/sm_make_chunk.c +++ b/net/sctp/sm_make_chunk.c @@ -2155,7 +2155,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net, case SCTP_PARAM_SET_PRIMARY: if (ep->asconf_enable) break; - goto fallthrough; + goto unhandled; case SCTP_PARAM_HOST_NAME_ADDRESS: /* Tell the peer, we won't support this param. */ @@ -2166,11 +2166,11 @@ static enum sctp_ierror sctp_verify_param(struct net *net, case SCTP_PARAM_FWD_TSN_SUPPORT: if (ep->prsctp_enable) break; - goto fallthrough; + goto unhandled; case SCTP_PARAM_RANDOM: if (!ep->auth_enable) - goto fallthrough; + goto unhandled; /* SCTP-AUTH: Secion 6.1 * If the random number is not 32 byte long the association @@ -2187,7 +2187,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net, case SCTP_PARAM_CHUNKS: if (!ep->auth_enable) - goto fallthrough; + goto unhandled; /* SCTP-AUTH: Section 3.2 * The CHUNKS parameter MUST be included once in the INIT or @@ -2203,7 +2203,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net, case SCTP_PARAM_HMAC_ALGO: if (!ep->auth_enable) - goto fallthrough; + goto unhandled; hmacs = (struct sctp_hmac_algo_param *)param.p; n_elt = (ntohs(param.p->length) - @@ -2226,7 +2226,7 @@ static enum sctp_ierror sctp_verify_param(struct net *net, retval = SCTP_IERROR_ABORT; } break; -fallthrough: +unhandled: default: pr_debug("%s: unrecognized param:%d for chunk:%d\n", __func__, ntohs(param.p->type), cid); -- 2.15.0
next prev parent reply other threads:[~2019-10-05 16:46 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-05 16:46 [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword Joe Perches 2019-10-05 16:46 ` Joe Perches [this message] 2019-10-07 18:08 ` [PATCH 1/4] net: sctp: Rename fallthrough label to unhandled Nick Desaulniers 2019-10-10 20:34 ` Kees Cook 2019-10-11 12:20 ` Neil Horman 2019-10-05 16:46 ` [PATCH 2/4] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use Joe Perches 2019-10-05 17:17 ` Miguel Ojeda 2019-10-07 18:14 ` Nick Desaulniers 2019-10-07 18:28 ` Joe Perches 2019-10-10 20:37 ` Kees Cook 2019-10-11 22:25 ` Miguel Ojeda 2019-10-05 16:46 ` [PATCH 3/4] Documentation/process: Add fallthrough pseudo-keyword Joe Perches 2019-10-05 17:47 ` Miguel Ojeda 2019-10-09 21:51 ` Nick Desaulniers 2019-10-05 16:46 ` [PATCH 4/4] scripts/cvt_style.pl: Tool to reformat sources in various ways Joe Perches 2019-10-05 17:31 ` Miguel Ojeda 2019-10-06 6:35 ` Joe Perches 2019-10-10 20:39 ` Kees Cook 2019-10-10 20:48 ` Joe Perches 2019-10-09 22:37 ` Nick Desaulniers 2019-10-11 16:29 ` [PATCH 0/4] treewide: Add 'fallthrough' pseudo-keyword Linus Torvalds 2019-10-11 17:43 ` Joe Perches 2019-10-11 17:46 ` Linus Torvalds 2019-10-12 2:14 ` Joe Perches 2019-10-11 18:01 ` Miguel Ojeda 2019-10-11 22:07 ` Kees Cook 2019-10-11 22:26 ` Miguel Ojeda
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2e0111756153d81d77248bc8356bac78925923dc.1570292505.git.joe@perches.com \ --to=joe@perches.com \ --cc=acme@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=alexander.shishkin@linux.intel.com \ --cc=bp@alien8.de \ --cc=clang-built-linux@googlegroups.com \ --cc=davem@davemloft.net \ --cc=gustavo@embeddedor.com \ --cc=hpa@zytor.com \ --cc=jolsa@redhat.com \ --cc=kan.liang@linux.intel.com \ --cc=keescook@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sctp@vger.kernel.org \ --cc=marcelo.leitner@gmail.com \ --cc=miguel.ojeda.sandonis@gmail.com \ --cc=namhyung@kernel.org \ --cc=natechancellor@gmail.com \ --cc=ndesaulniers@google.com \ --cc=netdev@vger.kernel.org \ --cc=nhorman@tuxdriver.com \ --cc=pavel@ucw.cz \ --cc=shawn@git.icu \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ --cc=vyasevich@gmail.com \ --cc=x86@kernel.org \ --subject='Re: [PATCH 1/4] net: sctp: Rename fallthrough label to unhandled' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).