From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Ashish Mhetre <amhetre@nvidia.com>,
krzysztof.kozlowski@linaro.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, digetx@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org
Cc: vdumpa@nvidia.com, Snikam@nvidia.com
Subject: Re: [Patch v10 1/4] memory: tegra: Add memory controller channels support
Date: Fri, 29 Apr 2022 17:56:50 +0300 [thread overview]
Message-ID: <2e0df511-f9fa-2905-f381-fc1158774ab4@collabora.com> (raw)
In-Reply-To: <20220429113438.13988-2-amhetre@nvidia.com>
On 4/29/22 14:34, Ashish Mhetre wrote:
> static int tegra186_mc_probe(struct tegra_mc *mc)
> {
> + struct platform_device *pdev = to_platform_device(mc->dev);
> + unsigned int i;
> int err;
>
> + mc->bcast_ch_regs = devm_platform_ioremap_resource_byname(pdev, "broadcast");
> + if (IS_ERR(mc->bcast_ch_regs)) {
> + if (PTR_ERR(mc->bcast_ch_regs) == -EINVAL) {
> + dev_warn(&pdev->dev, "Broadcast channel is missing, please update your device-tree\n");
> + mc->bcast_ch_regs = NULL;
> + goto skip_map_regs;
> + }
> + return PTR_ERR(mc->bcast_ch_regs);
> + }
> +
> + mc->ch_regs = devm_kcalloc(mc->dev, mc->soc->num_channels,
> + sizeof(*mc->ch_regs), GFP_KERNEL);
> + if (!mc->ch_regs)
> + return -ENOMEM;
> +
> + for (i = 0; i < mc->soc->num_channels; i++) {
> + char name[5];
> +
> + snprintf(name, sizeof(name), "ch%u", i);
> + mc->ch_regs[i] = devm_platform_ioremap_resource_byname(pdev, name);
> + if (IS_ERR(mc->ch_regs[i]))
> + return PTR_ERR(mc->ch_regs[i]);
> + }
> +
> +skip_map_regs:
> err = of_platform_populate(mc->dev->of_node, NULL, NULL, mc->dev);
More common to name labels by the action pointed by label, like
"populate:" in this case. No need to make v11 because of that.
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
next prev parent reply other threads:[~2022-04-29 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 11:34 [Patch v10 0/4] memory: tegra: Add MC channels and error logging Ashish Mhetre
2022-04-29 11:34 ` [Patch v10 1/4] memory: tegra: Add memory controller channels support Ashish Mhetre
2022-04-29 14:56 ` Dmitry Osipenko [this message]
2022-04-29 11:34 ` [Patch v10 2/4] memory: tegra: Add MC error logging on tegra186 onward Ashish Mhetre
2022-04-29 11:34 ` [Patch v10 3/4] dt-bindings: memory: tegra: Update validation for reg and reg-names Ashish Mhetre
2022-04-29 11:34 ` [Patch v10 4/4] arm64: tegra: Add memory controller channels Ashish Mhetre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e0df511-f9fa-2905-f381-fc1158774ab4@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=Snikam@nvidia.com \
--cc=amhetre@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vdumpa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).