From: Wang Jianchao <jianchao.wan9@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Josef Bacik <jbacik@fb.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC V4 1/6] blk: prepare to make blk-rq-qos pluggable and modular
Date: Wed, 23 Feb 2022 11:08:36 +0800 [thread overview]
Message-ID: <2e17c058-8917-4a37-896e-1093446339f6@gmail.com> (raw)
In-Reply-To: <YhUbCH+dhKkgMirE@slm.duckdns.org>
On 2022/2/23 1:19 上午, Tejun Heo wrote:
> Hello,
>
> On Thu, Feb 17, 2022 at 11:13:44AM +0800, Wang Jianchao (Kuaishou) wrote:
>> (3) Add /sys/block/x/queue/qos
>> We can use '+name' or "-name" to open or close the blk-rq-qos
>> policy.
>
> I don't understand why we're modularizing rq-qos in this non-standard way
> instead of modprobing to enable a policy and rmmoding to disable. Why are we
> building in qos names into the kernel and adding an extra module handling
> interface?
Hi Tejun
We just want to provide the flexibility for the user to open/close a policy
per device. If we need to the policy on a device, we needn't to waste cpu
cycles and memory for it.
Thanks
Jianchao
next prev parent reply other threads:[~2022-02-23 3:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 3:13 [RFC V4 0/6] blk: make blk-rq-qos policies pluggable and modular Wang Jianchao (Kuaishou)
2022-02-17 3:13 ` [RFC V4 1/6] blk: prepare to make blk-rq-qos " Wang Jianchao (Kuaishou)
2022-02-17 8:48 ` Christoph Hellwig
2022-02-18 3:34 ` Wang Jianchao
2022-02-22 17:19 ` Tejun Heo
2022-02-23 3:08 ` Wang Jianchao [this message]
2022-02-23 3:10 ` Wang Jianchao
2022-02-23 21:37 ` Tejun Heo
2022-02-24 1:51 ` Wang Jianchao
2022-02-24 2:07 ` Tejun Heo
2022-02-24 2:50 ` Wang Jianchao
2022-02-24 16:53 ` Tejun Heo
2022-02-25 2:02 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 2/6] blk-wbt: make wbt pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:50 ` Christoph Hellwig
2022-02-18 3:41 ` Wang Jianchao
2022-02-22 8:12 ` Christoph Hellwig
2022-02-17 3:13 ` [RFC V4 3/6] blk-iolatency: make iolatency pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:51 ` Christoph Hellwig
2022-02-18 3:42 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 4/6] blk-iocost: make iocost pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:52 ` Christoph Hellwig
2022-02-18 3:43 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 5/6] blk-ioprio: make ioprio pluggable and modular Wang Jianchao (Kuaishou)
2022-02-17 8:54 ` Christoph Hellwig
2022-02-17 3:13 ` [RFC V4 6/6] blk: export the sysfs for switching qos Wang Jianchao (Kuaishou)
2022-02-17 8:55 ` Christoph Hellwig
2022-02-18 3:43 ` Wang Jianchao
2022-02-17 3:21 ` [RFC V4 0/6] blk: make blk-rq-qos policies pluggable and modular Jens Axboe
2022-02-17 3:53 ` Wang Jianchao
2022-02-17 8:43 ` Christoph Hellwig
2022-02-18 3:22 ` Wang Jianchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e17c058-8917-4a37-896e-1093446339f6@gmail.com \
--to=jianchao.wan9@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).