From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD69C433FE for ; Mon, 3 Oct 2022 09:44:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbiJCJn7 (ORCPT ); Mon, 3 Oct 2022 05:43:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbiJCJn0 (ORCPT ); Mon, 3 Oct 2022 05:43:26 -0400 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6450D5EDCD for ; Mon, 3 Oct 2022 02:38:04 -0700 (PDT) Received: by mail-lf1-f48.google.com with SMTP id d6so1598730lfs.10 for ; Mon, 03 Oct 2022 02:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=8nV0XrY8LZwpXKpS4srGP447Rz/X7Xn90y9nTiydLdc=; b=XwqTitDaS7EOxqP2oFBSsCw/UYztR/Ok4NhYrMv/PXJpDxBSKCfOoAC1yF5MH4ayqx bBXdYQVXTzyCzwo7Tw3maWoqXJCGatYGHWCB0XewyXzsyATJtvq+NT7xlz9/TqJqOdRa SbNkAaavG9yoxdm51YftNldYVbUKBKEogb109Xdcdlf4TF/lvs485wGTz9MpO6WnrIhB ZhKOyQ2COtEjB17EofmtSpHCwg5VBAZnPYivmYWIkiAGmYxCWLFTCPauuo/uS1qoHZ09 Zn6yIDwxjk6j1M5bIEpyIQc+M0UP9jrsPbU7Xd5kKIRsEkCsJLcymTFRMi6ty0/KB4C+ yaKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=8nV0XrY8LZwpXKpS4srGP447Rz/X7Xn90y9nTiydLdc=; b=1ITPpVOH0kWU4lQYlLOww7lXau1N4BoInKraJltndYARa2bsEFpF6WaCWXJZrmlMXa eVrrA51nLSLBuKzcmRiOpdeH/tpJuZC0eUYV3wTRlYr5FmXIAnT/Fahr/b5G7pEv+Xpj 2QNifiSW5d81fOx+n7J8DuvlXL7jyaSdMefWdl3mQ3vcNFnYWwNxd3Szwo5w12BIleYt CLEqmgdag6xe0c8nkS2xcg83EYfDv4f2CkWYTkcv1X6qtGlYLCC8j+9O/3slr4ucRlv/ pg9ItrR9GYxaS75HDsqN8ET5w0+VaGknyxCpZDNRCKEDpPpqdncYlxte5Ox4Ar6DomHq PzUA== X-Gm-Message-State: ACrzQf1LZ0WYIV8OYETRYKNjOshmtwAqpkF57qRl3xjYNLFp624ijWnI 4ILU8JqX9LMBUp0ww9GN6gKPJSuNbF1//w== X-Google-Smtp-Source: AMsMyM5pTl0qUUUrQmICcRfAVFgObBRocvyvNf1nO9MIfn8wkSwOtyrbuiWQdIfrfDViIIdeS2Vw+g== X-Received: by 2002:ac2:558b:0:b0:4a2:2706:43f6 with SMTP id v11-20020ac2558b000000b004a2270643f6mr2874558lfg.601.1664789579388; Mon, 03 Oct 2022 02:32:59 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id i2-20020a2ea362000000b0026c2fec2f8esm841555ljn.84.2022.10.03.02.32.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 02:32:58 -0700 (PDT) Message-ID: <2e68d64f-766c-0a52-9df8-74f0681a5973@linaro.org> Date: Mon, 3 Oct 2022 11:32:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to yaml Content-Language: en-US To: Bhupesh Sharma Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, netdev@vger.kernel.org, Bjorn Andersson , Rob Herring , Vinod Koul , David Miller References: <20220929060405.2445745-1-bhupesh.sharma@linaro.org> <20220929060405.2445745-4-bhupesh.sharma@linaro.org> <4e896382-c666-55c6-f50b-5c442e428a2b@linaro.org> <1163e862-d36a-9b5e-2019-c69be41cc220@linaro.org> <9999a1a3-cda0-2759-f6f4-9bc7414f9ee4@linaro.org> <0aeb2c5e-9a5e-90c6-a974-f2a0b866d64f@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/10/2022 10:29, Bhupesh Sharma wrote: > On Sun, 2 Oct 2022 at 13:24, Krzysztof Kozlowski > wrote: >> >> On 01/10/2022 14:51, Bhupesh Sharma wrote: >>>>> Right, most of them are to avoid the make dtbs_check errors / warnings >>>>> like the one mentioned above. >>>> >>>> All of them should not be here. >>> >>> I guess only 'snps,reset-gpio' need not be replicated here, as for >>> others I still see 'dtbs_check' error, if they are not replicated here: >>> >>> >>> arch/arm64/boot/dts/qcom/sm8150-hdk.dtb: ethernet@20000: Unevaluated >>> properties are not allowed ('power-domains', 'resets', 'rx-fifo-depth', >>> 'tx-fifo-depth' were unexpected) >>> From schema: /Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> >>> Am I missing something here? >> >> Probably the snps,dwmac schema failed. It is then considered >> unevaluated, so such properties are unknown for qcom,ethqos schema. Run >> check with snps,dwmac and fix all errors first. > > Running dt_binding_check DT_SCHEMA_FILES=net/snps,dwmac.yaml > reports no error currently. Then it's something in your commits. I don't know what you wrote, as you did not sent a commit. I cannot reproduce your errors after removing unneeded power-domains. Just to clarify - I am testing only the dt_binding_check (so only the examples - I assume they are meaningful). Best regards, Krzysztof