From: Mikko Perttunen <cyndis@kapsi.fi>
To: Aapo Vienamo <avienamo@nvidia.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Mikko Perttunen <mperttunen@nvidia.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] arm64: dts: tegra210-p2180: Correct sdmmc4 vqmmc-supply
Date: Wed, 25 Jul 2018 09:53:44 +0300 [thread overview]
Message-ID: <2e6f0b68-38df-8cfd-9d6b-6de08bcaf97c@kapsi.fi> (raw)
In-Reply-To: <1532090746-15863-7-git-send-email-avienamo@nvidia.com>
Technically this shouldn't be required since VDD_1V8 is always on
anyway, but I think it's nicer to specify regulators anyway, so +1!
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
On 20.07.2018 15:45, Aapo Vienamo wrote:
> On p2180 sdmmc4 is powered from a fixed 1.8 V regulator.
>
> Signed-off-by: Aapo Vienamo <avienamo@nvidia.com>
> ---
> arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> index 8496101..053458a 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2180.dtsi
> @@ -273,6 +273,7 @@
> status = "okay";
> bus-width = <8>;
> non-removable;
> + vqmmc-supply = <&vdd_1v8>;
> };
>
> clocks {
>
next prev parent reply other threads:[~2018-07-25 6:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 12:45 [PATCH 0/7] Tegra SDHCI enable 1.8 V signaling on Tegar210 and Tegra186 Aapo Vienamo
2018-07-20 12:45 ` [PATCH 1/7] dt-bindings: Document Tegra SDHCI pinctrl bindings Aapo Vienamo
2018-07-25 6:47 ` Mikko Perttunen
2018-07-20 12:45 ` [PATCH 2/7] mmc: tegra: Reconfigure pad voltages during voltage switching Aapo Vienamo
2018-07-25 6:41 ` Mikko Perttunen
2018-07-25 8:35 ` Aapo Vienamo
2018-07-20 12:45 ` [PATCH 3/7] arm64: dts: Add Tegra210 sdmmc pinctrl voltage states Aapo Vienamo
2018-07-21 0:14 ` kbuild test robot
2018-07-25 6:49 ` Mikko Perttunen
2018-07-20 12:45 ` [PATCH 4/7] arm64: dts: Add Tegra186 " Aapo Vienamo
2018-07-21 1:29 ` kbuild test robot
2018-07-25 6:50 ` Mikko Perttunen
2018-07-20 12:45 ` [PATCH 5/7] arm64: dts: tegra210-p2180: Allow ldo2 to go down to 1.8 V Aapo Vienamo
2018-07-25 6:50 ` Mikko Perttunen
2018-07-20 12:45 ` [PATCH 6/7] arm64: dts: tegra210-p2180: Correct sdmmc4 vqmmc-supply Aapo Vienamo
2018-07-25 6:53 ` Mikko Perttunen [this message]
2018-07-20 12:45 ` [PATCH 7/7] arm64: dts: tegra210-p2597: Remove no-1-8-v from sdmmc1 Aapo Vienamo
2018-07-25 6:58 ` Mikko Perttunen
2018-07-25 8:12 ` Aapo Vienamo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e6f0b68-38df-8cfd-9d6b-6de08bcaf97c@kapsi.fi \
--to=cyndis@kapsi.fi \
--cc=adrian.hunter@intel.com \
--cc=avienamo@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).