From: Stefan Berger <stefanb@linux.ibm.com>
To: Saulo Alessandre <saulo.alessandre@gmail.com>
Cc: davem@davemloft.net, dhowells@redhat.com,
herbert@gondor.apana.org.au, keyrings@vger.kernel.org,
linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org, patrick@puiterwijk.org,
zohar@linux.ibm.com,
Saulo Alessandre <saulo.alessandre@tse.jus.br>
Subject: Re: [PATCH v2 1/3] add params and ids to support nist_p384
Date: Mon, 22 Feb 2021 13:37:41 -0500 [thread overview]
Message-ID: <2e829730-bb0c-47eb-70f2-731c184eba33@linux.ibm.com> (raw)
In-Reply-To: <20210222175850.1131780-1-saulo.alessandre@gmail.com>
On 2/22/21 12:58 PM, Saulo Alessandre wrote:
> From: Saulo Alessandre <saulo.alessandre@tse.jus.br>
>
> * crypto/asymmetric_keys/x509_cert_parser.c
> - prepare x509 parser to load nist_secp384r1
>
> * crypto/ecc_curve_defs.h
> - add nist_p384 params
>
> * include/crypto/ecdh.h
> - add ECC_CURVE_NIST_P384
>
> * include/linux/oid_registry.h
> - reorder OID_id_ecdsa_with_sha1
> - add OID_id_secp384r1
>
> Signed-off-by: Saulo Alessandre <saulo.alessandre@tse.jus.br>
I would separate this patch into an x509: and certs: part since it
touches two subsystems.
I can take this series of patches and post my v9 including them at the
end. This would make it easier for others to test. I would massage them
a bit, including the separation of the 1st patch into 2 patches, if you
don't mind, preserving your Signed-off-by. I need to fix something in my
v8 regarding registration failure handling. Let me know whether this is
fine with you.
I had tested your patches over the weekend with my endless test tool
creating keys in user space and loading them into the kernel. It worked
fine for NIST p256 & p384. Also signing kernel modules with NIST p384 is
working fine.
So, for the series:
Tested-by: Stefan Berger <stefanb@linux.ibm.com>
Regards,
Stefan
next prev parent reply other threads:[~2021-02-22 20:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 16:25 [PATCH v8 0/4] Add support for x509 certs with NIST p256 and p192 keys Stefan Berger
2021-02-15 16:25 ` [PATCH v8 1/4] crypto: Add support for ECDSA signature verification Stefan Berger
2021-02-15 16:25 ` [PATCH v8 2/4] x509: Detect sm2 keys by their parameters OID Stefan Berger
2021-02-15 16:25 ` [PATCH v8 3/4] x509: Add support for parsing x509 certs with ECDSA keys Stefan Berger
2021-02-15 16:25 ` [PATCH v8 4/4] ima: Support EC keys for signature verification Stefan Berger
2021-02-19 18:56 ` [PATCH 1/3] add params and ids to support nist_p384 Saulo Alessandre
2021-02-19 18:57 ` Saulo Alessandre
2021-02-19 18:57 ` [PATCH 2/3] add mathematic to support fast nist_p384 and change routines to pass forward ecc_curve Saulo Alessandre
2021-02-19 19:27 ` Stefan Berger
2021-02-19 18:57 ` [PATCH 3/3] add nist_p384 register and unregister to support nist_p384 Saulo Alessandre
2021-02-19 19:19 ` Stefan Berger
2021-02-19 19:28 ` [PATCH 1/3] add params and ids " Stefan Berger
2021-02-22 17:58 ` [PATCH v2 " Saulo Alessandre
2021-02-22 17:58 ` [PATCH v2 2/3] adds math to support nist_p384 fast and changes routines to pass forward ecc_curve Saulo Alessandre
2021-02-22 17:58 ` [PATCH v2 3/3] adds nist_p384 register and unregister to support nist_p384 and tests Saulo Alessandre
2021-02-22 18:37 ` Stefan Berger [this message]
2021-02-24 13:35 ` [PATCH v2 1/3] add params and ids to support nist_p384 Saulo Alessandre de Lima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e829730-bb0c-47eb-70f2-731c184eba33@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@puiterwijk.org \
--cc=saulo.alessandre@gmail.com \
--cc=saulo.alessandre@tse.jus.br \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).