From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226F9C433ED for ; Tue, 27 Apr 2021 11:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3546613E2 for ; Tue, 27 Apr 2021 11:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235988AbhD0Lrt (ORCPT ); Tue, 27 Apr 2021 07:47:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230365AbhD0Lrr (ORCPT ); Tue, 27 Apr 2021 07:47:47 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D634CC061574; Tue, 27 Apr 2021 04:47:03 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id n138so93367221lfa.3; Tue, 27 Apr 2021 04:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6mN7UJosAzy0Fgag1DI+J5II0Cv8JwYcpqR0ZdaZ6Pw=; b=VXVdlKxet0oHyPdjnO6HFu2QcGCTj2OnpNUQBPewkERKV+sw2dsktG1hLLOs3DcZaO 9DOXKyYVY6Tza+Oa/28VnQIzzIzhF2iS6NwC91VoSxakURxdNl3e2QqsRBj1NBRCZkwI edbTrVaohbDwNfjnP8OUaT/PNSySXJdBF0wLnz/EPNa5DOaZhXwbWlrDuKzgVuPNwiDD 2Zdpm0gQ+laaB0mM1y4PZOUmOYhtytVWEnFv88OojOpD3ngTCQTKjrnLE8Q6NbEPBWQS oNfsAvXkSyXdQlDMnf66Ju89qCVFs0AiOCZDF/iVmjAZJXhgeASyrIYcCc8REWBl2hxo r5VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6mN7UJosAzy0Fgag1DI+J5II0Cv8JwYcpqR0ZdaZ6Pw=; b=Cla9HqcPT0NCHpcRPnz1rX6/1ah6Lo2Gs2oUMODbxYHq4xvO3yoLIrhLR35MB8XFxY h392OzxVG+CeSnG8O9sD3BmfR4SUYfBIu7CKpvswRsdg7YFZv+O33vPuVvFjumdzJI00 YCFP/grMz4f4pXy10Nf3F1iGeaevsbrjYkCt8ajFexj5Q2/UXxfIVrV+8Ar6r28Y6zp7 Gd4u5u64r6E55VtOm9vlzouXGo4OOJdnlIDWhqEzvBUv1v4Kx+L9nNtzR4zHw1NIaiD8 rsGdDKesK6XREBPttrYvUrPVtMxWOoHGkmNakK2Pp7md3GtXDeWEFYxLbucxmtTc9usJ O8pQ== X-Gm-Message-State: AOAM5318D1pVFj844fxj6N2aWqaP/fROmeejb57g5qYOXj8vq8jgR6ai H0vWZzrULE6sl3Ch8oIed3Z2y3W7ih0= X-Google-Smtp-Source: ABdhPJx6kko3TABajn1fiMhwaIKekxa1aDYYmrMmB2KvhSCMsDtZmlLmkmnRpfkACnQvOdILCmZEfA== X-Received: by 2002:a19:a40a:: with SMTP id q10mr16261069lfc.302.1619524022256; Tue, 27 Apr 2021 04:47:02 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-102.dynamic.spd-mgts.ru. [109.252.193.102]) by smtp.googlemail.com with ESMTPSA id i8sm363303ljb.43.2021.04.27.04.47.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Apr 2021 04:47:01 -0700 (PDT) Subject: Re: [PATCH v3 25/79] staging: media: vde: use pm_runtime_resume_and_get() To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , Jonathan Hunter , Mauro Carvalho Chehab , Thierry Reding , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org References: From: Dmitry Osipenko Message-ID: <2e8bdea5-b2a7-df95-9d93-7c1f2df6158d@gmail.com> Date: Tue, 27 Apr 2021 14:47:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 27.04.2021 13:26, Mauro Carvalho Chehab пишет: > @@ -1088,8 +1090,9 @@ static int tegra_vde_remove(struct platform_device *pdev) > { > struct tegra_vde *vde = platform_get_drvdata(pdev); > struct device *dev = &pdev->dev; > + int ret; > > - pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); Should be cleaner to return error directly here, IMO. > pm_runtime_dont_use_autosuspend(dev); > pm_runtime_disable(dev); > > @@ -1097,7 +1100,8 @@ static int tegra_vde_remove(struct platform_device *pdev) > * Balance RPM state, the VDE power domain is left ON and hardware > * is clock-gated. It's safe to reboot machine now. > */ > - pm_runtime_put_noidle(dev); > + if (ret >= 0) > + pm_runtime_put_noidle(dev); > clk_disable_unprepare(vde->clk);