From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>
Cc: alsa-devel@alsa-project.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
kjlu@umn.edu, Liam Girdwood <liam.r.girdwood@linux.intel.com>,
emamd001@umn.edu, smccaman@umn.edu,
Thomas Gleixner <tglx@linutronix.de>,
Enrico Weigelt <info@metux.net>,
linux-kernel@vger.kernel.org,
Navid Emamdoost <navid.emamdoost@gmail.com>
Subject: Re: [alsa-devel] [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids
Date: Fri, 27 Sep 2019 11:37:24 -0500 [thread overview]
Message-ID: <2e8ef4df-9c5f-f6e0-23ee-32d3bc555330@linux.intel.com> (raw)
In-Reply-To: <20190927153304.GS32742@smile.fi.intel.com>
> The problem with solution #1 is freeing orphaned pointer. It will work,
> but it's simple is not okay from object life time prospective.
?? I don't get your point at all Andy.
Two allocations happens in a loop and if the second fails, you free the
first and then jump to free everything allocated in the previous
iterations. what am I missing?
next prev parent reply other threads:[~2019-09-27 16:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 16:19 [PATCH v2] ASoC: Intel: Skylake: prevent memory leak in snd_skl_parse_uuids Navid Emamdoost
2019-09-25 17:05 ` Pierre-Louis Bossart
2019-09-27 2:55 ` Navid Emamdoost
2019-09-27 13:14 ` Pierre-Louis Bossart
2019-09-27 15:10 ` Cezary Rojewski
2019-09-27 15:33 ` Andy Shevchenko
2019-09-27 16:37 ` Pierre-Louis Bossart [this message]
2019-09-27 20:39 ` [alsa-devel] " Andy Shevchenko
2019-09-27 22:25 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e8ef4df-9c5f-f6e0-23ee-32d3bc555330@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=emamd001@umn.edu \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kjlu@umn.edu \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).