From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<rdunlap@infradead.org>, <linux@arm.linux.org.uk>,
<daniel.lezcano@linaro.org>, <tglx@linutronix.de>,
<thierry.reding@gmail.com>, <florian.vaussard@epfl.ch>,
<jic23@kernel.org>, <jason@lakedaemon.net>, <andrew@lunn.ch>,
<silvio.fricke@gmail.com>, <heiko.stuebner@bq.com>,
<olof@lixom.net>, <sebastian.hesselbarth@gmail.com>,
<sboyd@codeaurora.org>, <gregory.clement@free-electrons.com>,
<arnd@arndb.de>, <robherring2@gmail.com>, <marc.zyngier@arm.com>,
<maxime.ripard@free-electrons.com>, <devicetree@vger.kernel.org>,
<linux-doc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: add mtk-timer bindings
Date: Tue, 13 May 2014 06:08:07 -0700 [thread overview]
Message-ID: <2e93c984-96d9-4504-bb9a-672a247fb710@BL2FFO11FD034.protection.gbl> (raw)
In-Reply-To: <1399938570-11356-3-git-send-email-matthias.bgg@gmail.com>
Hi Matthias,
On Tue, 2014-05-13 at 01:49AM +0200, Matthias Brugger wrote:
> Add binding documentation for the General Porpose Timer driver of
> the Mediatek SoCs.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> .../devicetree/bindings/timer/mediatek,mtk-timer.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>
> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> new file mode 100644
> index 0000000..d0f2df3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> @@ -0,0 +1,18 @@
> +Mediatek MT6589, MT6577 and MT6572 Timers
> +---------------------------------------
> +
> +Required properties:
> +- compatible: Should be "mediatek,mtk6589-timer"
> +- reg: Should contain location and length for timers register.
> +- clocks: phandle to the clock source; the first refers to a 13 MHz fixed
> + system clock and the second handle to a 32 KHz fixed RTC
> + clock.
Are these frequencies mandatory to the timer or an implementation
detail of the SOC you're working with? I suspect, it might be possible
to see the same timer in a different SOC implementation with different
frequencies? In that case - or probably in general - the frequencies
should not be part of the binding, IMHO.
> +
> +Examples:
> +
> + timer {
> + compatible = "mediatek,mtk6589-timer";
> + reg = <0x10008000 0x80>;
> + interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&system_clk>, <&rtc_clk>;
Might be just my personal preference, but you could also add the clock-names
property which would relax the ordering requirement a bit and would
clearly identify the IP's clocks.
Sören
next prev parent reply other threads:[~2014-05-13 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 23:49 [PATCH v3 0/6] arm: Add basic support for Mediatek Cortex-A7 SoCs Matthias Brugger
2014-05-12 23:49 ` [PATCH v3 1/6] clocksource: Add support for the Mediatek SoCs Matthias Brugger
2014-05-13 5:54 ` Maxime Ripard
2014-05-12 23:49 ` [PATCH v3 2/6] dt-bindings: add mtk-timer bindings Matthias Brugger
2014-05-13 13:08 ` Sören Brinkmann [this message]
2014-05-12 23:49 ` [PATCH v3 3/6] vendor-prefixes: add prefix for Mediaktek Inc Matthias Brugger
2014-05-12 23:49 ` [PATCH v3 4/6] arm: add basic support for Mediatek MT6589 boards Matthias Brugger
2014-05-13 22:47 ` Stephen Boyd
2014-05-14 7:00 ` Maxime Ripard
2014-05-14 21:26 ` Stephen Boyd
2014-05-15 7:58 ` Arnd Bergmann
2014-05-12 23:49 ` [PATCH v3 5/6] dt-bindings: add documentation for Mediatek SoC Matthias Brugger
2014-05-12 23:49 ` [PATCH v3 6/6] arm: mediatek: add dts for Aquaris5 mobile phone Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e93c984-96d9-4504-bb9a-672a247fb710@BL2FFO11FD034.protection.gbl \
--to=soren.brinkmann@xilinx.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=heiko.stuebner@bq.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@free-electrons.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=silvio.fricke@gmail.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).