From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E24CC07E95 for ; Tue, 13 Jul 2021 10:06:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16BF26117A for ; Tue, 13 Jul 2021 10:06:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235382AbhGMKJR (ORCPT ); Tue, 13 Jul 2021 06:09:17 -0400 Received: from mta-02.yadro.com ([89.207.88.252]:43958 "EHLO mta-01.yadro.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235109AbhGMKJQ (ORCPT ); Tue, 13 Jul 2021 06:09:16 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 818A149DF5; Tue, 13 Jul 2021 10:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= content-transfer-encoding:mime-version:user-agent:content-type :content-type:organization:references:in-reply-to:date:date:from :from:subject:subject:message-id:received:received:received; s= mta-01; t=1626170784; x=1627985185; bh=ygupXc4lMRIGiPL6uvH/IC3wh N2q8kFut/9Bk5A6nZc=; b=qcgv65a0DzSzNjeHNwdR6kwb1EOlGhV00P+jL8j9O a1ZedZcK94BSNPscDmhvywjrxC4qgdZO1jK7ru43l53VyB1Op8CSdqBCTV+Gz8ua 5aEKkTs43ME5UktyMI26Jjxb8IcX9gLbEkH/K8El1EAY2nqDEgvY5YRkBBclFjKo ps= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SeLZvwBkyIei; Tue, 13 Jul 2021 13:06:24 +0300 (MSK) Received: from T-EXCH-03.corp.yadro.com (t-exch-03.corp.yadro.com [172.17.100.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id E6B40412FB; Tue, 13 Jul 2021 13:06:22 +0300 (MSK) Received: from [10.199.0.247] (10.199.0.247) by T-EXCH-03.corp.yadro.com (172.17.100.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Tue, 13 Jul 2021 13:06:22 +0300 Message-ID: <2e961640f0d14fec87854a6c11c5f86b2380516d.camel@yadro.com> Subject: Re: [PATCH v2 2/3] net/ncsi: add NCSI Intel OEM command to keep PHY up From: Ivan Mikhaylov To: Joel Stanley , Eddie James CC: "David S . Miller" , Jakub Kicinski , Samuel Mendoza-Jonas , "Benjamin Herrenschmidt" , Networking , Linux Kernel Mailing List , OpenBMC Maillist Date: Tue, 13 Jul 2021 13:16:09 +0300 In-Reply-To: References: <20210708122754.555846-1-i.mikhaylov@yadro.com> <20210708122754.555846-3-i.mikhaylov@yadro.com> Organization: YADRO Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.199.0.247] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-03.corp.yadro.com (172.17.100.103) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-07-12 at 10:01 +0000, Joel Stanley wrote: > On Thu, 8 Jul 2021 at 12:27, Ivan Mikhaylov wrote: > > > > This allows to keep PHY link up and prevents any channel resets during > > the host load. > > > > It is KEEP_PHY_LINK_UP option(Veto bit) in i210 datasheet which > > block PHY reset and power state changes. > > How about using runtime configuration over using kconfig for this, so > the same kernel config can be used on different machines. Something > device tree based? As I see there is already the way with Kconfig option, with previous broadcom/mellanox get mac address and set affinity for mellanox commands. I'm not sure about dts based solution. As I see there is two ways: 1. make everything related OEM into dts based options 2. or this way, with Kconfig > > Another option is to use the netlink handler to send the OEM command > from userspace. Eddie has worked on this for an IBM machine, and I've > asked him to post those changes. I would prefer the kernel option > though. > I like the idea, it may help with debugging. Thanks. >