From: Paolo Bonzini <pbonzini@redhat.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
Christian Brauner <christian.brauner@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, keescook@chromium.org
Subject: Re: [PATCH v2 4/6] selftests: pidfd: do not use ksft_exit_skip after ksft_set_plan
Date: Tue, 7 Jul 2020 11:49:50 +0200 [thread overview]
Message-ID: <2e98d690-2202-4183-5b49-942f29b0a955@redhat.com> (raw)
In-Reply-To: <f0b60da1-ce3f-da53-9ffc-94fea233181a@linuxfoundation.org>
On 06/07/20 22:55, Shuah Khan wrote:
> On 6/24/20 12:21 AM, Paolo Bonzini wrote:
>> On 23/06/20 22:44, Christian Brauner wrote:
>>>> ret = sys_pidfd_send_signal(pidfd, 0, NULL, 0);
>>>> if (ret < 0) {
>>>> - if (errno == ENOSYS)
>>>> - ksft_exit_skip(
>>>> + if (errno == ENOSYS) {
>>>> + ksft_test_result_skip(
>>>> "%s test: pidfd_send_signal() syscall not
>>>> supported\n",
>>>> test_name);
>>> If pidfd_send_signal() is not supported, you're falling through and then
>>> you're reporting:
>>>
>>> ok 5 # SKIP pidfd_send_signal check for support test:
>>> pidfd_send_signal() syscall not supported
>>> ok 6 pidfd_send_signal check for support test: pidfd_send_signal()
>>> syscall is supported. Tests can be executed
>>
>> You're right, this needs a "return".
>>
>
> Hi Paulo,
>
> I am applying the rest of the patches in this series except this one.
> Please send v3 for this.
Thanks, I was actually going to send everything but you're making it
even simpler. I'll send v3 of this patch only.
Paolo
next prev parent reply other threads:[~2020-07-07 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 0:15 [PATCH v2 0/6] kselftest: fix TAP output for skipped test and ksft_set_plan misuse Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 1/6] kselftest: fix TAP output for skipped tests Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 2/6] selftests: breakpoints: fix computation of test plan Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 3/6] selftests: breakpoints: do not use ksft_exit_skip after ksft_set_plan Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 4/6] selftests: pidfd: " Paolo Bonzini
2020-06-23 20:44 ` Christian Brauner
2020-06-24 6:21 ` Paolo Bonzini
2020-07-06 20:55 ` Shuah Khan
2020-07-07 9:49 ` Paolo Bonzini [this message]
2020-06-23 0:15 ` [PATCH v2 5/6] selftests: sigaltstack: " Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 6/6] selftests: sync_test: " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e98d690-2202-4183-5b49-942f29b0a955@redhat.com \
--to=pbonzini@redhat.com \
--cc=christian.brauner@ubuntu.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).