From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>,
Sven Schuchmann <schuchmann@schleissheimer.de>
Cc: Rob Herring <robh+dt@kernel.org>, <linux-leds@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] leds: lp50xx: remove unused regulator
Date: Wed, 3 Feb 2021 07:49:35 -0600 [thread overview]
Message-ID: <2e9dff78-7fde-404d-6fad-6aeedf1145d1@ti.com> (raw)
In-Reply-To: <20210203090249.GA14154@amd>
Pavel
On 2/3/21 3:02 AM, Pavel Machek wrote:
> On Wed 2021-02-03 08:34:08, Sven Schuchmann wrote:
>> The regulator for vled-supply is unused in the driver.
>> It is just assigned from DT and disabled in lp50xx_remove.
>> So the code can be removed from the driver.
> Dan, what is going on here? Do we need to also enable the regulator,
> or is the removal correct thing to do?
>
I think it would be better to do an enable as opposed to removing the code.
This would be needed especially in applications that have to meet strict
power management requirements.
Users may want to disable or enable the regulator during suspend/resume.
Otherwise it would be considered always-on and the regulator does not
need to be populated.
Dan
next prev parent reply other threads:[~2021-02-03 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 8:34 [PATCH 2/2] leds: lp50xx: remove unused regulator Sven Schuchmann
2021-02-03 9:02 ` Pavel Machek
2021-02-03 13:49 ` Dan Murphy [this message]
2021-02-03 14:23 ` Pavel Machek
2021-02-03 16:02 ` Dan Murphy
2021-02-03 16:26 ` AW: " Sven Schuchmann
2021-02-04 14:47 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9dff78-7fde-404d-6fad-6aeedf1145d1@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=schuchmann@schleissheimer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).