From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754989AbcFGU2e (ORCPT ); Tue, 7 Jun 2016 16:28:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33495 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753216AbcFGU2b (ORCPT ); Tue, 7 Jun 2016 16:28:31 -0400 Subject: Re: [PATCH V6 8/8] vfio: platform: check reset call return code during release To: Sinan Kaya , kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, eric.auger@linaro.org References: <1464472878-27176-1-git-send-email-okaya@codeaurora.org> <1464472878-27176-9-git-send-email-okaya@codeaurora.org> Cc: linux-acpi@vger.kernel.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal , Alex Williamson , linux-kernel@vger.kernel.org From: Auger Eric Message-ID: <2ecf0796-f711-8554-9567-061f3ac5e6eb@redhat.com> Date: Tue, 7 Jun 2016 22:28:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464472878-27176-9-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 07 Jun 2016 20:28:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sinan, Le 29/05/2016 à 00:01, Sinan Kaya a écrit : > Release call is ignoring the return code from reset call and can > potentially continue even though reset call failed. > > If reset_required module parameter is set, this patch is going > to validate the return code and will cause stack dump with > WARN_ON and warn the user of failure. > > Signed-off-by: Sinan Kaya > --- > drivers/vfio/platform/vfio_platform_common.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c > index 962cfb1..bb05ca0 100644 > --- a/drivers/vfio/platform/vfio_platform_common.c > +++ b/drivers/vfio/platform/vfio_platform_common.c > @@ -243,7 +243,15 @@ static void vfio_platform_release(void *device_data) > mutex_lock(&driver_lock); > > if (!(--vdev->refcnt)) { > - vfio_platform_call_reset(vdev, NULL); > + const char *extra_dbg = NULL; > + int ret; > + > + ret = vfio_platform_call_reset(vdev, &extra_dbg); > + if (ret && vdev->reset_required) { > + dev_warn(vdev->device, "reset driver is required and reset call failed in release (%d) %s\n", > + ret, extra_dbg ? extra_dbg : ""); > + WARN_ON(1); > + } > vfio_platform_regions_cleanup(vdev); > vfio_platform_irq_cleanup(vdev); > } > Looks OK to me Reviewed-by: Eric Auger Thanks Eric