From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD1DC433EF for ; Thu, 14 Apr 2022 09:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241767AbiDNJbq (ORCPT ); Thu, 14 Apr 2022 05:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241762AbiDNJbj (ORCPT ); Thu, 14 Apr 2022 05:31:39 -0400 Received: from mxout03.lancloud.ru (mxout03.lancloud.ru [45.84.86.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED3365D5ED; Thu, 14 Apr 2022 02:29:12 -0700 (PDT) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru C51A620A19A5 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH V2] clk: renesas: Fix memory leak of 'cpg' To: Haowen Bai , Geert Uytterhoeven , Michael Turquette , Stephen Boyd CC: , , References: <1649837953-10984-1-git-send-email-baihaowen@meizu.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <2ed01eb3-ff46-425c-75dc-81729a5c30a8@omp.ru> Date: Thu, 14 Apr 2022 12:29:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1649837953-10984-1-git-send-email-baihaowen@meizu.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 4/13/22 11:19 AM, Haowen Bai wrote: > Fix this issue by freeing the cpg when exiting the function in the > error/normal path. > > Signed-off-by: Haowen Bai > --- > V1->V2: free both cpg&clks. > > drivers/clk/renesas/clk-r8a73a4.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) 2 patches with the same name won't do -- you always need to include the chip name part of the file name in the subject (in this case r8a73a4). MBR, Sergey